Fix context managers in `bench.py` (#802)

I'm sloppy and didn't test this last change prior to merging.
This commit is contained in:
Charlie Marsh 2024-01-05 16:24:45 -05:00 committed by GitHub
parent ac385c80ab
commit fc76f979e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 11 deletions

View File

@ -4,7 +4,7 @@ This script assumes that `pip`, `pip-tools`, `virtualenv`, and `hyperfine` are
installed, and that a Puffin release builds exists at `./target/release/puffin` installed, and that a Puffin release builds exists at `./target/release/puffin`
(relative to the repository root). (relative to the repository root).
Example usage: python bench.py -f requirements.in -t puffin -t pip-tools Example usage: python bench.py -t puffin -t pip-tools requirements.in
""" """
import abc import abc
import argparse import argparse
@ -91,7 +91,7 @@ class Suite(abc.ABC):
class PipTools(Suite): class PipTools(Suite):
def resolve_cold(self, requirements_file: str, *, verbose: bool) -> None: def resolve_cold(self, requirements_file: str, *, verbose: bool) -> None:
with tempfile.mkdtemp() as temp_dir: with tempfile.TemporaryDirectory() as temp_dir:
cache_dir = os.path.join(temp_dir, ".cache") cache_dir = os.path.join(temp_dir, ".cache")
output_file = os.path.join(temp_dir, "requirements.txt") output_file = os.path.join(temp_dir, "requirements.txt")
@ -122,7 +122,7 @@ class PipTools(Suite):
) )
def resolve_warm(self, requirements_file: str, *, verbose: bool) -> None: def resolve_warm(self, requirements_file: str, *, verbose: bool) -> None:
with tempfile.mkdtemp() as temp_dir: with tempfile.TemporaryDirectory() as temp_dir:
cache_dir = os.path.join(temp_dir, ".cache") cache_dir = os.path.join(temp_dir, ".cache")
output_file = os.path.join(temp_dir, "requirements.txt") output_file = os.path.join(temp_dir, "requirements.txt")
@ -152,7 +152,7 @@ class PipTools(Suite):
) )
def install_cold(self, requirements_file: str, *, verbose: bool) -> None: def install_cold(self, requirements_file: str, *, verbose: bool) -> None:
with tempfile.mkdtemp() as temp_dir: with tempfile.TemporaryDirectory() as temp_dir:
cache_dir = os.path.join(temp_dir, ".cache") cache_dir = os.path.join(temp_dir, ".cache")
venv_dir = os.path.join(temp_dir, ".venv") venv_dir = os.path.join(temp_dir, ".venv")
@ -182,7 +182,7 @@ class PipTools(Suite):
) )
def install_warm(self, requirements_file: str, *, verbose: bool) -> None: def install_warm(self, requirements_file: str, *, verbose: bool) -> None:
with tempfile.mkdtemp() as temp_dir: with tempfile.TemporaryDirectory() as temp_dir:
cache_dir = os.path.join(temp_dir, ".cache") cache_dir = os.path.join(temp_dir, ".cache")
venv_dir = os.path.join(temp_dir, ".venv") venv_dir = os.path.join(temp_dir, ".venv")
@ -214,7 +214,7 @@ class PipTools(Suite):
class Puffin(Suite): class Puffin(Suite):
def resolve_cold(self, requirements_file: str, *, verbose: bool) -> None: def resolve_cold(self, requirements_file: str, *, verbose: bool) -> None:
with tempfile.mkdtemp() as temp_dir: with tempfile.TemporaryDirectory() as temp_dir:
cache_dir = os.path.join(temp_dir, ".cache") cache_dir = os.path.join(temp_dir, ".cache")
output_file = os.path.join(temp_dir, "requirements.txt") output_file = os.path.join(temp_dir, "requirements.txt")
@ -252,7 +252,7 @@ class Puffin(Suite):
) )
def resolve_warm(self, requirements_file: str, *, verbose: bool) -> None: def resolve_warm(self, requirements_file: str, *, verbose: bool) -> None:
with tempfile.mkdtemp() as temp_dir: with tempfile.TemporaryDirectory() as temp_dir:
cache_dir = os.path.join(temp_dir, ".cache") cache_dir = os.path.join(temp_dir, ".cache")
output_file = os.path.join(temp_dir, "requirements.txt") output_file = os.path.join(temp_dir, "requirements.txt")
@ -290,7 +290,7 @@ class Puffin(Suite):
) )
def install_cold(self, requirements_file: str, *, verbose: bool) -> None: def install_cold(self, requirements_file: str, *, verbose: bool) -> None:
with tempfile.mkdtemp() as temp_dir: with tempfile.TemporaryDirectory() as temp_dir:
cache_dir = os.path.join(temp_dir, ".cache") cache_dir = os.path.join(temp_dir, ".cache")
venv_dir = os.path.join(temp_dir, ".venv") venv_dir = os.path.join(temp_dir, ".venv")
@ -327,7 +327,7 @@ class Puffin(Suite):
) )
def install_warm(self, requirements_file: str, *, verbose: bool) -> None: def install_warm(self, requirements_file: str, *, verbose: bool) -> None:
with tempfile.mkdtemp() as temp_dir: with tempfile.TemporaryDirectory() as temp_dir:
cache_dir = os.path.join(temp_dir, ".cache") cache_dir = os.path.join(temp_dir, ".cache")
venv_dir = os.path.join(temp_dir, ".venv") venv_dir = os.path.join(temp_dir, ".venv")
@ -376,7 +376,7 @@ def main():
description="Benchmark Puffin against other packaging tools." description="Benchmark Puffin against other packaging tools."
) )
parser.add_argument( parser.add_argument(
"-f", "--file", type=str, help="The file to read the dependencies from." "file", type=str, help="The file to read the dependencies from."
) )
parser.add_argument( parser.add_argument(
"--verbose", "-v", action="store_true", help="Print verbose output." "--verbose", "-v", action="store_true", help="Print verbose output."
@ -435,7 +435,7 @@ def main():
case Tool.PUFFIN: case Tool.PUFFIN:
suite = Puffin() suite = Puffin()
case _: case _:
raise ValueError(f"Unknown tool: {tool}") raise ValueError(f"Invalid tool: {tool}")
suite.run_benchmark(benchmark, requirements_file, verbose=verbose) suite.run_benchmark(benchmark, requirements_file, verbose=verbose)