mirror of https://github.com/astral-sh/uv
56521937b7
<!--
Thank you for contributing to uv! To help us out with reviewing, please
consider the following:
- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title?
- Does this pull request include references to any relevant issues?
-->
## Summary
I started learning `uv` by inspecting the source code.
I've noticed that your shell scripts are very good! Which is rare!
## Test Plan
I propose to add `shellcheck` to the CI.
It is a great tool to help finding bugs and style issues in shell code.
Techincal details:
- This CI job will only run when any `.sh` files are changed (or the job
definition file)
- It takes just several seconds even on local machine:
```
» time shellcheck -S style **/*.sh
shellcheck -S style **/*.sh 0.02s user 0.05s system 61% cpu 0.123 total
```
- It is easy to use, for example: I just fixed the single problem you
had in your code with `# shellcheck disable=SC1091`
- I am using this tool for around 8 years now and didn't have any
issues. Examples:
|
||
|---|---|---|
| .. | ||
| benchmark | ||
| links | ||
| packages | ||
| popular_packages | ||
| publish | ||
| requirements | ||
| scenarios | ||
| workspaces | ||
| check_cache_compat.py | ||
| check_embedded_python.py | ||
| check_system_python.py | ||
| release.sh | ||
| sync_scenarios.sh | ||
| transform_readme.py | ||
| update_schemastore.py | ||
| uv-run-remote-script-test.py | ||