From 1826033fb0016ae8bfca8fea5a94171cff0b1c2a Mon Sep 17 00:00:00 2001
From: Drew T <50529377+Druthulu@users.noreply.github.com>
Date: Thu, 6 Aug 2026 10:55:38 -0600
Subject: [PATCH] fix(phase-30 S44 I.1c): the R36 citizenship gate is no longer
 blind to non-ov_ binary classes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- onboarded() derived from EVERY config/splat.<alias>.yaml (R33; templates + us.exe normalized) —
  was splat.ov_*.yaml + a hand-set {main,resident}: the gate that exists to catch unwired binaries
  was itself structurally blind to any class it did not know about.
- CHECK 4 widened: resident + modules must appear in the family map too (only main is exempt —
  structurally barren, checked twice in S39). New honest warn: resident missing from the current
  map (family_hseq widening lands next commit).
- NEGATIVE CONTROL: a planted config/splat.md_TEST.yaml FAILS check 1 ('MISSING md_TEST — invisible
  to every derived tool'); removing it restores OK over the 140.
---
 tools/audit_binaries.py | 29 +++++++++++++++++++++--------
 1 file changed, 21 insertions(+), 8 deletions(-)

diff --git a/tools/audit_binaries.py b/tools/audit_binaries.py
index 0bcbd422b3..0cf43c7a99 100644
--- a/tools/audit_binaries.py
+++ b/tools/audit_binaries.py
@@ -37,10 +37,19 @@ SHARED_INCLUDE = "shared/engine_core.h"
 
 
 def onboarded():
-    """The authoritative onboarded set, DERIVED from the splat configs the build consumes (R33)."""
-    ovs = {os.path.basename(p)[len("splat."):-len(".yaml")]
-           for p in glob.glob(os.path.join(REPO, "config/splat.ov_*.yaml"))}
-    return {"main", "resident"} | ovs
+    """The authoritative onboarded set, DERIVED from the splat configs the build consumes (R33).
+
+    P30 S44: was `splat.ov_*.yaml` + a hand-set {main, resident} — i.e. the R36 citizenship gate was
+    itself structurally blind to any binary class it did not know about (the exact defect class it
+    exists to catch). Now: EVERY `config/splat.<alias>.yaml` is an onboarded binary, whatever its
+    class ("main" is `splat.us.exe.yaml` — normalize it)."""
+    out = set()
+    for p in glob.glob(os.path.join(REPO, "config/splat.*.yaml")):
+        alias = os.path.basename(p)[len("splat."):-len(".yaml")]
+        if alias in ("us.exe", "us.overlay.template", "us.module.template"):
+            continue
+        out.add(alias)
+    return {"main"} | out
 
 
 def dedup_membership():
@@ -81,7 +90,7 @@ def main():
         if not cfg:
             continue                                   # already flagged by CHECK 1
         if not os.path.exists(os.path.join(REPO, cfg["sig"])):
-            fails.append(f"{b}: no sig at {cfg['sig']} (run `make sig-overlays` / `make sig-resident`)")
+            fails.append(f"{b}: no sig at {cfg['sig']} (run `make sig-overlays` / `make sig-resident` / `make sig-modules`)")
 
     # --- CHECK 3 (the load-bearing SC07 check): every onboarded OVERLAY's .c includes the shared
     # engine-core header. Without it NO shared body can be instantiated in that overlay, so it can
@@ -108,7 +117,9 @@ def main():
         for g in fam.get("families", []):
             for o, _ in g.get("members", []) + g.get("matched_members", []):
                 fam_ovs.add(o)
-        map_missing = {b for b in onb if b.startswith("ov_")} - fam_ovs
+        # S44: modules (md_*) carry shareable engine functions too; only main is exempt
+        # (structurally barren, checked twice — S39). Resident + overlays + modules must appear.
+        map_missing = {b for b in onb if b != "main"} - fam_ovs
         # An overlay can be legitimately absent only if it shares NO function with any other (never,
         # in practice — every overlay shares the engine core). Flag, do not hard-fail, since the map
         # is regenerable and may legitimately post-date a brand-new onboarding.
@@ -127,8 +138,10 @@ def main():
                      f"candidate for tools/dedup_extend.py): {zero if verbose else zero[:6]}")
 
     # --- report
-    print(f"audit-binaries: {len(onb)} onboarded (main + resident + "
-          f"{len([b for b in onb if b.startswith('ov_')])} overlays)")
+    n_ov = len([b for b in onb if b.startswith("ov_")])
+    n_md = len([b for b in onb if b.startswith("md_")])
+    print(f"audit-binaries: {len(onb)} onboarded (main + resident + {n_ov} overlays"
+          + (f" + {n_md} modules" if n_md else "") + ")")
     if verbose:
         print(f"  dup_report.BINARIES: {len(binaries)}  |  family-map overlays: "
               f"{len(fam_ovs) if os.path.exists(fam_path) else 'n/a'}")