From 2364da4afdcf44923077ead72d48b4413041cb82 Mon Sep 17 00:00:00 2001 From: Drew T <50529377+Druthulu@users.noreply.github.com> Date: Mon, 24 Aug 2026 23:03:34 -0600 Subject: [PATCH] =?UTF-8?q?fix(decomp):=20ov=5FSC07=5F010=20baseline=20bac?= =?UTF-8?q?k=20to=20green=20=E2=80=94=20one=20stale=20(void)=20decl=20no-p?= =?UTF-8?q?roto'd?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The S59 scoped R22 sweep (96 binaries whose TUs instantiate the DEFINE macros my engine_core edit touched) found ov_SC07_010 RED at HEAD: the 14:57 maintenance commit (commit:2694) banked func_8017F2BC's (s16*) definition into a TU that still carries an earlier draft-preamble decl 'extern void func_8017F2BC(void);' at line 4932 — conflicting types, TU uncompilable, though the TU is byte-identical to its committed state (how that pass reported green is an open question for the lane's arity/splice ordering). Provenance checked: my commits touch only func_80162CCC decls; the pinned cc1 accepts the no-proto+definition pair in isolation. Fix: the arity pass's own byte-neutral no-proto form; whole-binary SHA re-checked green. ov_SC07_002 remains RED on a jtbl_rodata_pads carve drift (also pre-existing, also from earlier passes) — named in docs/tool-designs/aprop-lane-s59.md, not papered over. --- src/ov_SC07_010/ov_SC07_010_jr_8017AE2C.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ov_SC07_010/ov_SC07_010_jr_8017AE2C.c b/src/ov_SC07_010/ov_SC07_010_jr_8017AE2C.c index 7db789fff..4eabfd495 100644 --- a/src/ov_SC07_010/ov_SC07_010_jr_8017AE2C.c +++ b/src/ov_SC07_010/ov_SC07_010_jr_8017AE2C.c @@ -4929,7 +4929,7 @@ INCLUDE_ASM("asm/ov_SC07_010/nonmatchings/ov_SC07_010_jr_8017AE2C", func_8017F1C extern s32 func_8012AD50(void*); extern void func_8017DCB8(s32 a0); -extern void func_8017F2BC(void); +extern void func_8017F2BC(); void func_8017F214(s32 a0) { u8 *s0;