diff --git a/phase-ends/current/PHASE_PLAN.md b/phase-ends/current/PHASE_PLAN.md index 04198db676..9a2d6cde7a 100644 --- a/phase-ends/current/PHASE_PLAN.md +++ b/phase-ends/current/PHASE_PLAN.md @@ -81,7 +81,7 @@ C0507 (§458 struct spelling per-access dial), C0508 (§459 declaration-layer by Out of scope (other phases): jr-merged callers (3.44), void-def/`$v0` and zero-arg `$a0` callers, return-type lies (3.40), cast sites (3.39). Grep callers before any signature unit. - T7 | done | expert-opus55 | title: milestone gate and record | coder: none | effort: medium | files: docs/struct-map.md, docs/levers.md, cookbook/, phase-ends/current/ | done-when: `--check-structs` exit 0 on a fresh census; R22 218/218 at the closing commit; `type_census --selftest`, `restruct --selftest --real`, `lever_progress --check` OK; `docs/struct-map.md` regenerated; cookbook §396(a) correction and the phase's generalizable gotchas added via `tools/cookbook_add.sh` | verify: `.venv/bin/python tools/type_census.py --out-dir .run/P38/census --no-cache --check-structs && make clean && make extract-all JOBS=16 && make check-all JOBS=16` | reads: tasks/T1.md, tasks/T4.md, tasks/T5.md, tasks/T6.md | deps: T6 | est-ctx: 60k | review: no | wait-for: — - T8 | done | expert-opus55 | coder: opus55 | effort: medium | title: docs/formats.md: LIST.CD verified on US, runtime reader, repack note (issue #2) | files: docs/formats.md | done-when: docs/formats.md §2.3 marked verified on US (8 tables in order, 0xE40 bytes); §2.1 names LoaderInitFileTable (0x8001971C) and cdFileLocTable (0x800AE830) as the runtime reader; a note says repacking must rebuild LIST.CD and the ISO directory; docs link check passes; no ROM bytes added (R74) | verify: — | reads: — | deps: — | est-ctx: — | review: no | wait-for: — -- T9 | queued | expert-opus55 | coder: none | effort: medium | title: story §10 + retrospective §7 for P37 T5-close, PA3 migration and P38 | files: docs/story.md, docs/retrospective.md, docs/story-timeline.md, docs/story-timeline.svg | done-when: both sections cover P37 T5-close, the migration (retired-doc breakage, PhaseEnd id normalisation, .run/ blanket ignore) and P38 (believed/failed with denominators, the gate-reading decision and why); §7 heading Phases 35-38; timeline.py regenerated; no cost tables, no reporter or reply text | verify: — | reads: tasks/T1.md, tasks/T5.md, tasks/T5.1.md, tasks/T6.md, tasks/T7.md | deps: T7 | est-ctx: 70k | review: yes | wait-for: — +- T9 | done | expert-opus55 | coder: none | effort: medium | title: story §10 + retrospective §7 for P37 T5-close, PA3 migration and P38 | files: docs/story.md, docs/retrospective.md, docs/story-timeline.md, docs/story-timeline.svg | done-when: both sections cover P37 T5-close, the migration (retired-doc breakage, PhaseEnd id normalisation, .run/ blanket ignore) and P38 (believed/failed with denominators, the gate-reading decision and why); §7 heading Phases 35-38; timeline.py regenerated; no cost tables, no reporter or reply text | verify: — | reads: tasks/T1.md, tasks/T5.md, tasks/T5.1.md, tasks/T6.md, tasks/T7.md | deps: T7 | est-ctx: 70k | review: yes | wait-for: — - T10 | queued | expert-opus55 | coder: opus55 | effort: medium | title: publish the P38 type census in README and timeline | files: tools/progress.py, tools/timeline.py, .gitignore, README.md, docs/progress.json, docs/story-timeline.* | done-when: progress.py reads the current census (no hard-coded .run/P37 path); README Types paragraph shows the P38 close counts; timeline gains a struct-definitions column; .run/P38/census type_census.{json,txt} tracked; make tools-health OK | verify: make tools-health | reads: — | deps: T7 | est-ctx: 60k | review: no | wait-for: — ## Risks @@ -110,3 +110,5 @@ C0507 (§458 struct spelling per-access dial), C0508 (§459 declaration-layer by - 2026-09-30 router: T8 next -> done - 2026-09-30 developer: added T9 — story §10 + retrospective §7 for P37 T5-close, PA3 migration and P38 - 2026-09-30 developer: added T10 — publish the P38 type census in README and timeline +- 2026-09-30 developer: T9 next -> done +- 2026-09-30 developer: developer: T10 also refreshes docs/story.md §11 Gen3 row from the P38 census (1,650 definitions, 53 listed twins, 229 lying declarations) — docs/story.md added to T10 files diff --git a/phase-ends/current/discussions/review-20260930-193212.md b/phase-ends/current/discussions/review-20260930-193212.md new file mode 100644 index 0000000000..05c9308632 --- /dev/null +++ b/phase-ends/current/discussions/review-20260930-193212.md @@ -0,0 +1,13 @@ +# REVIEW — Phase 3.38, T9 + +What ran: tools/timeline.py, timeline.py --check, doc_links.py (local) +Results at: docs/story.md §10 (new paragraphs after "wait for the exit."), docs/retrospective.md §7 +What the expert saw: story §10 and retrospective §7 now cover the end of old P37, the PA3 migration and P38 + +Decisions needed: +- Lying-declaration wording: one field named twice (checked in source) vs the brief's "different metric" — Recommended: keep as written +- The 17-day gap and the decision reasoning are stated as unrecorded — Recommended: add the owner's own reason if wanted, else keep +- §11 snapshot left at 2026-09-12 — Recommended: refresh in T10 + +Plan edits proposed: +- none