mirror of
https://github.com/Druthulu/BFM-decomp
synced 2026-09-26 13:33:34 -04:00
Drew T
0cda15c6de
Pre-existing latent breakage (Phase-21 close commit:0292, "+62 PsyQ names"), found during T5b's R22 fleet verify. A genuinely-clean `make clean` + re-extract + build of `main` failed with dozens of `can't open asm/nonmatchings/800c3/func_*.s` — clean-rebuild broken since Phase 21, masked all along by incremental builds reusing stale pre-rename .s/.o (the exact R22 failure mode). - Root cause (byte-proven): Phase-21 xdedup renamed 62 PsyQ library functions to their proper names (InitHeap, FlushCache, GetTPage, SysEnqIntRP, SpuWrite, CdMix, __main …) in symbols.us.txt, but never regenerated/renamed the committed src/*.c stub refs that call them by the OLD func_<ADDR> name. splat's FRESH regeneration of a stub .c uses the CURATED names (move src/800c3.c aside -> splat writes INCLUDE_ASM(InitHeap) + emits InitHeap.s); the committed stubs were simply stale. - Fix: rename all 62 INCLUDE_ASM(func_<ADDR>) -> the curated name across 12 files (800c.c 1, 800c3.c 22, apicard1/2/4 4/6/2, boot.c 1, libcd1.c 8, libetc.c 6, libgpu.c 3, sgap.c 1, snd1.c 7, snd2.c 1). Pure rename to match splat's canonical output; byte-neutral. - VERIFIED: main clean-builds 143dbb89 from a fully clean tree; full clean fleet check-all 136/136. - Lesson (cookbook): a symbols.us.txt rename must be propagated to (a) shared-macro bodies (engine_core.h — the T5b GetTPage fix) AND (b) INCLUDE_ASM stub refs (this), AND verified by a genuinely-clean check-all (make clean + full re-extract), never incremental. Added a lint check.
20 lines
523 B
C
20 lines
523 B
C
#include "common.h"
|
|
|
|
INCLUDE_ASM("asm/nonmatchings/apicard2", firstfile2);
|
|
|
|
INCLUDE_ASM("asm/nonmatchings/apicard2", _card_info);
|
|
|
|
INCLUDE_ASM("asm/nonmatchings/apicard2", _card_load);
|
|
|
|
INCLUDE_ASM("asm/nonmatchings/apicard2", _card_write);
|
|
|
|
INCLUDE_ASM("asm/nonmatchings/apicard2", _new_card);
|
|
|
|
INCLUDE_ASM("asm/nonmatchings/apicard2", func_80062298);
|
|
|
|
INCLUDE_ASM("asm/nonmatchings/apicard2", func_800622D0);
|
|
|
|
INCLUDE_ASM("asm/nonmatchings/apicard2", StartCARD);
|
|
|
|
INCLUDE_ASM("asm/nonmatchings/apicard2", func_80062360);
|