David Racine fdb7e194cc fix(audio): bounds-check fontId to stop OOB crash with large SAF packs (#6916) ...

AudioLoad_IsFontLoadComplete had a stub `return true` that bypassed all
load-status checks, masking an out-of-bounds write: for large SAF packs
(many custom sequences) SetFontLoadStatus indexed fontLoadStatus[] with
fontId values larger than the fontMapSize-sized array, causing heap
corruption and semi-random crashes.

Remove the stub. Add a (size_t)fontId >= fontMapSize guard in both the
check and the setter: out-of-range IDs (custom SAF sequences that carry
no associated soundfont) are treated as "loaded" in the check and
silently skipped in the write, matching prior observable behavior while
eliminating the OOB access.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-07-13 12:12:43 +00:00

..

assets

Fix presets, regressed from LACS decoupling (#6919)

2026-07-13 04:22:04 +00:00

CMake

sccache for windows builds (#3385)

2024-02-01 23:11:31 -06:00

include

Add save state wiring for Barinade, Bongo Bongo, & Morpha (#6914)

2026-07-12 22:35:19 +00:00

macosx

Macos game mode support (#4993)

2025-02-04 10:48:41 +01:00

platform

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

soh

Rando: UX improvements of Locations page (#6817)

2026-07-13 04:11:18 +00:00

src

fix(audio): bounds-check fontId to stop OOB crash with large SAF packs (#6916)

2026-07-13 12:12:43 +00:00

.clang-format

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

.clang-tidy

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

.gitattributes

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

.gitignore

Pass for some warning fixes (#4501)

2024-10-31 07:42:27 -07:00

.gitrepo

git subrepo push soh

2022-07-14 20:47:48 -04:00

CMakeLists.txt

wire decomp static savestates with macros (#6904)

2026-07-12 15:09:47 +00:00

fixbaserom.py

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

format.sh

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

icon.jpg

Nintendo switch support (#935)

2022-07-25 21:11:53 -04:00

properties.h.in

clean up cmake configure files (#4002)

2024-04-20 11:03:41 -04:00

resource.h

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

Resource.rc

update lus includes for new LUS file structure (#5820)

2025-10-09 16:50:51 -07:00

SHIPOFHARKINIAN.ico

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

SHIPOFHARKINIAN.manifest

Use manifest for windows DPI awareness (#3270) (#4256)

2024-08-05 19:31:20 -04:00