differentiate debug and release artifacts for flatpaks

.github/workflows/validate.yml

@@ -160,6 +160,9 @@ jobs:
   build-flatpak:
     name: Build Flatpak
     runs-on: ubuntu-24.04
+    strategy:
+      matrix:
+        preset: ["Flatpak-Debug", "Flatpak-Release"]
     env:
       FLATPAK_ID: io.github.hedge_dev.unleashedrecomp
 
@@ -185,7 +188,7 @@ jobs:
         uses: actions/cache@v4
         with:
           path: /tmp/ccache
-          key: ccache-${{ runner.os }}
+          key: ccache-${{ runner.os }}-${{ matrix.preset }}
 
       - name: Prepare Project
         run: cp ./private/* ./UnleashedRecompLib/private
@@ -198,13 +201,13 @@ jobs:
         run: |
           echo "commit_message=$(git log -1 --pretty=%s)" >> $GITHUB_ENV
           export CCACHE_DIR=/tmp/ccache
-          flatpak-builder --user --force-clean --install-deps-from=flathub --repo=repo --ccache builddir ./flatpak/${{ env.FLATPAK_ID }}.json
+          flatpak-builder --user --force-clean --install-deps-from=flathub --repo=repo --ccache builddir ./flatpak/${{ env.FLATPAK_ID }}-${{ matrix.preset }}.json
           flatpak build-bundle repo ./${{ env.FLATPAK_ID }}.flatpak ${{ env.FLATPAK_ID }} --runtime-repo=https://flathub.org/repo/flathub.flatpakrepo
 
       - name: Upload Artifact
         uses: actions/upload-artifact@v4
         with:
-          name: UnleashedRecomp-Flatpak
+          name: UnleashedRecomp-${{ matrix.preset }}
           path: ./${{ env.FLATPAK_ID }}.flatpak
   build-macos:
     name: Build macOS

UnleashedRecomp/patches/misc_patches.cpp

@@ -193,29 +193,3 @@ PPC_FUNC(sub_824EE620)
 
     ctx.r3.u32 = PersistentStorageManager::ShouldDisplayDLCMessage(true);
 }
-
-// This is a constructor for some struct that constructed inside CTownManContext::CTownManContext()
-// and within the calls contained in CTownManBase::ProcMsgSetTownManRetryTimeTable().
-// 
-// Within the constructor of the CTownManContext, the second member of this struct is initialized to -1
-// after this call happens inside CTownManContext::CTownManContext() at pretty much the very of that function call.
-//
-// This initialization of the member variable is however not executed when this constructor for the struct
-// is called from someplace else in the game's code, as such it remains with unitialized data for that field.
-//
-// Ensuring that this member variable is initialized to 0 anytime this constructor is called fixes an issue with
-// Tails not disappearing when giving you the camera after Rooftop Run Act 1 (Night). This setting of it to 0 won't
-// break the behaviour created by the call to it from CTownManContext::CTownManContext() as that itself sets it to -1 later on.
-// It only affects other instance of the call.
-//
-// NOTE: ctx.r3.u32 + 0 is also unitialized by this constructor, however both instances of this function being called
-// initialized the said variable later on before being used.
-// 
-// NOTE: ctx.r3.u32 + 20 is also unitialized, however I could not find any uses for this. Since this is already
-// quite a big change due to the amount of NPCs in the game, I would rather not touch this unless an issue is found.
-PPC_FUNC_IMPL(__imp__sub_8297C630);
-PPC_FUNC(sub_8297C630)
-{
-    PPC_STORE_U32(ctx.r3.u32 + 4, 0);
-    __imp__sub_8297C630(ctx, base);
-}

flatpak/io.github.hedge_dev.unleashedrecomp-Flatpak-Debug.json

@@ -0,0 +1,48 @@
+{
+  "id": "io.github.hedge_dev.unleashedrecomp",
+  "runtime": "org.freedesktop.Platform",
+  "runtime-version": "24.08",
+  "sdk": "org.freedesktop.Sdk",
+  "sdk-extensions" : [ "org.freedesktop.Sdk.Extension.llvm18" ],
+  "finish-args": [
+    "--share=network",
+    "--socket=wayland",
+    "--socket=fallback-x11",
+    "--socket=pulseaudio",
+    "--device=all",
+    "--filesystem=host",
+    "--filesystem=/media",
+    "--filesystem=/run/media",
+    "--filesystem=/mnt"
+  ],
+  "modules": [
+    {
+      "name": "UnleashedRecomp",
+      "buildsystem": "simple",
+      "build-commands": [
+        "cmake --preset linux-debug -DUNLEASHED_RECOMP_FLATPAK=ON -DSDL2MIXER_VORBIS=VORBISFILE -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_C_COMPILER_LAUNCHER=ccache",
+        "cmake --build out/build/linux-debug --target UnleashedRecomp",
+        "mkdir -p /app/bin",
+        "cp out/build/linux-debug/UnleashedRecomp/UnleashedRecomp /app/bin/UnleashedRecomp",
+        "install -Dm644 UnleashedRecompResources/images/game_icon.png /app/share/icons/hicolor/128x128/apps/${FLATPAK_ID}.png",
+        "install -Dm644 flatpak/io.github.hedge_dev.unleashedrecomp.metainfo.xml /app/share/metainfo/${FLATPAK_ID}.metainfo.xml",
+        "install -Dm644 flatpak/io.github.hedge_dev.unleashedrecomp.desktop /app/share/applications/${FLATPAK_ID}.desktop"
+      ],
+      "sources": [
+        {
+          "type": "dir",
+          "path": "../"
+        }
+      ],
+      "build-options": {
+        "no-debuginfo": true,
+        "strip": false,
+        "append-path": "/usr/lib/sdk/llvm18/bin",
+        "prepend-ld-library-path": "/usr/lib/sdk/llvm18/lib",
+        "build-args": [
+          "--share=network"
+        ]
+      }
+    }
+  ]
+}