mirror
/
WSL
mirror of https://github.com/microsoft/WSL
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix parameter naming inconsistencies in WSLAContainerLauncher (#13911) 

* Initial plan

* Rename containerNetworkType parameter to ContainerNetworkType for naming consistency

Co-authored-by: ptrivedi <1638019+ptrivedi@users.noreply.github.com>

* Rename fds parameter to Fds in RunningWSLAContainer constructor

Co-authored-by: benhillis <17727402+benhillis@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ptrivedi <1638019+ptrivedi@users.noreply.github.com>
Co-authored-by: benhillis <17727402+benhillis@users.noreply.github.com>
This commit is contained in:
Copilot 2025-12-15 17:00:14 -05:00 committed by GitHub
parent 606dc8da80
commit 01ccb0805e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/windows/common/WSLAContainerLauncher.cpp
View File

@ -17,8 +17,8 @@ using wsl::windows::common::ClientRunningWSLAProcess;
using wsl::windows::common::RunningWSLAContainer; using wsl::windows::common::RunningWSLAContainer;
using wsl::windows::common::WSLAContainerLauncher; using wsl::windows::common::WSLAContainerLauncher;
RunningWSLAContainer::RunningWSLAContainer(wil::com_ptr<IWSLAContainer>&& Container, std::vector<WSLA_PROCESS_FD>&& fds) : RunningWSLAContainer::RunningWSLAContainer(wil::com_ptr<IWSLAContainer>&& Container, std::vector<WSLA_PROCESS_FD>&& Fds) :
m_container(std::move(Container)), m_fds(std::move(fds)) m_container(std::move(Container)), m_fds(std::move(Fds))
{ {
} }
@ -48,9 +48,9 @@ WSLAContainerLauncher::WSLAContainerLauncher(
const std::string& EntryPoint, const std::string& EntryPoint,
const std::vector<std::string>& Arguments, const std::vector<std::string>& Arguments,
const std::vector<std::string>& Environment, const std::vector<std::string>& Environment,
WSLA_CONTAINER_NETWORK_TYPE containerNetworkType, WSLA_CONTAINER_NETWORK_TYPE ContainerNetworkType,
ProcessFlags Flags) : ProcessFlags Flags) :
WSLAProcessLauncher(EntryPoint, Arguments, Environment, Flags), m_image(Image), m_name(Name), m_containerNetworkType(containerNetworkType) WSLAProcessLauncher(EntryPoint, Arguments, Environment, Flags), m_image(Image), m_name(Name), m_containerNetworkType(ContainerNetworkType)
{ {
} }

4
src/windows/common/WSLAContainerLauncher.h
View File

@ -22,7 +22,7 @@ class RunningWSLAContainer
public: public:
NON_COPYABLE(RunningWSLAContainer); NON_COPYABLE(RunningWSLAContainer);
DEFAULT_MOVABLE(RunningWSLAContainer); DEFAULT_MOVABLE(RunningWSLAContainer);
RunningWSLAContainer(wil::com_ptr<IWSLAContainer>&& Container, std::vector<WSLA_PROCESS_FD>&& fds); RunningWSLAContainer(wil::com_ptr<IWSLAContainer>&& Container, std::vector<WSLA_PROCESS_FD>&& Fds);
IWSLAContainer& Get(); IWSLAContainer& Get();
WSLA_CONTAINER_STATE State(); WSLA_CONTAINER_STATE State();
@ -45,7 +45,7 @@ public:
const std::string& EntryPoint = "", const std::string& EntryPoint = "",
const std::vector<std::string>& Arguments = {}, const std::vector<std::string>& Arguments = {},
const std::vector<std::string>& Environment = {}, const std::vector<std::string>& Environment = {},
WSLA_CONTAINER_NETWORK_TYPE containerNetworkType = WSLA_CONTAINER_NETWORK_TYPE::WSLA_CONTAINER_NETWORK_HOST, WSLA_CONTAINER_NETWORK_TYPE ContainerNetworkType = WSLA_CONTAINER_NETWORK_TYPE::WSLA_CONTAINER_NETWORK_HOST,
ProcessFlags Flags = ProcessFlags::Stdout | ProcessFlags::Stderr); ProcessFlags Flags = ProcessFlags::Stdout | ProcessFlags::Stderr);
void AddVolume(const std::string& HostPath, const std::string& ContainerPath, bool ReadOnly); void AddVolume(const std::string& HostPath, const std::string& ContainerPath, bool ReadOnly);