cleanup: minor tweaks to path translation failed messages

This commit is contained in:
Ben Hillis 2025-12-12 16:02:50 -08:00
parent f1e20b21c9
commit 4e78440739
3 changed files with 5 additions and 6 deletions

View File

@ -730,9 +730,6 @@ The system may need to be restarted so the changes can take effect.</value>
<data name="MessageFailedToResizeDisk" xml:space="preserve">
<value>Failed to resize disk.</value>
</data>
<data name="MessageFailedToTranslatePath" xml:space="preserve">
<value>Failed to translate path.</value>
</data>
<data name="MessageNoValueFound" xml:space="preserve">
<value>No value found.</value>
</data>

View File

@ -2884,14 +2884,16 @@ Return Value:
std::string TranslatedPath = WslPathTranslate(Path, 0, Mode);
if (TranslatedPath.empty())
{
auto WarningMessage = wsl::shared::Localization::MessageFailedToTranslate(Path);
if (wil::ScopedWarningsCollector::CanCollectWarning())
{
EMIT_USER_WARNING(wsl::shared::Localization::MessageFailedToTranslate(Path));
EMIT_USER_WARNING(std::move(WarningMessage));
}
else
{
LOG_ERROR("Failed to translate {}", Path);
LOG_WARNING("{}", WarningMessage);
}
continue;
}

View File

@ -137,7 +137,7 @@ Return Value:
auto translatedPath = WslPathTranslate(value.data(), TRANSLATE_FLAG_ABSOLUTE, TRANSLATE_MODE_UNIX);
if (translatedPath.empty())
{
std::cerr << Localization::MessageFailedToTranslatePath() << "\n";
std::cerr << Localization::MessageFailedToTranslate(value.data()) << "\n";
return 1;
}