mirror/Zelda64Recomp
1
0
Fork 0
mirror of https://github.com/Zelda64Recomp/Zelda64Recomp synced 2026-09-03 10:41:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

Close context when showing or hiding a context and reopen afterwards to prevent deadlocks

Browse Source
This commit is contained in:
Mr-Wiseguy
2025-04-23 23:31:10 -04:00
parent 2e8bd48747
commit ebd11b2d84
1 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ui/ui_state.cpp
+17 -5
View File
@@ -796,16 +796,28 @@ void recompui::message_box(const char* msg) {
} }
void recompui::show_context(ContextId context, std::string_view param) { void recompui::show_context(ContextId context, std::string_view param) {
std::lock_guard lock{ui_state_mutex}; ContextId prev_context = recompui::try_close_current_context();
{
std::lock_guard lock{ ui_state_mutex };
// TODO call the context's on_show callback with the param. // TODO call the context's on_show callback with the param.
ui_state->show_context(context); ui_state->show_context(context);
}
if (prev_context != ContextId::null()) {
prev_context.open();
}
} }
void recompui::hide_context(ContextId context) { void recompui::hide_context(ContextId context) {
std::lock_guard lock{ui_state_mutex}; ContextId prev_context = recompui::try_close_current_context();
{
std::lock_guard lock{ ui_state_mutex };
ui_state->hide_context(context); ui_state->hide_context(context);
}
if (prev_context != ContextId::null()) {
prev_context.open();
}
} }
void recompui::hide_all_contexts() { void recompui::hide_all_contexts() {