From 39c006bfb9f6f6ac36d04d648cb0004cb0db84ce Mon Sep 17 00:00:00 2001
From: RobertJoonas <56999674+RobertJoonas@users.noreply.github.com>
Date: Tue, 15 Jul 2025 09:59:11 +0300
Subject: [PATCH] Verification follow-up improvements (#5568)

* handle unhandled verification case

* log site domain on browserless errors

* mix format

* info -> warning to see the logs
---
 lib/plausible/verification/checks/installation.ex | 12 +++++++++---
 lib/plausible/verification/diagnostics.ex         |  5 +++--
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/lib/plausible/verification/checks/installation.ex b/lib/plausible/verification/checks/installation.ex
index 93182f5b85..fe5ee90b8d 100644
--- a/lib/plausible/verification/checks/installation.ex
+++ b/lib/plausible/verification/checks/installation.ex
@@ -100,11 +100,17 @@ defmodule Plausible.Verification.Checks.Installation do
         )
 
       {:ok, %{status: status, body: %{"data" => %{"error" => error}}}} ->
-        Logger.warning("[VERIFICATION] Browserless JS error: #{inspect(error)}")
+        Logger.warning(
+          "[VERIFICATION] Browserless JS error (data_domain='#{data_domain}'): #{inspect(error)}"
+        )
+
         put_diagnostics(state, plausible_installed?: false, service_error: status)
 
       {:error, %{reason: reason}} ->
-        Logger.warning("[VERIFICATION] Browserless request error: #{inspect(reason)}")
+        Logger.warning(
+          "[VERIFICATION] Browserless request error (data_domain='#{data_domain}'): #{inspect(reason)}"
+        )
+
         put_diagnostics(state, plausible_installed?: false, service_error: reason)
     end
   end
@@ -148,7 +154,7 @@ defmodule Plausible.Verification.Checks.Installation do
         }
         |> Map.merge(diffs)
 
-      Logger.info("[VERIFICATION] js_elixir_diff: #{inspect(info)}")
+      Logger.warning("[VERIFICATION] js_elixir_diff: #{inspect(info)}")
     end
 
     :telemetry.execute(telemetry_event(any_diff?), %{})
diff --git a/lib/plausible/verification/diagnostics.ex b/lib/plausible/verification/diagnostics.ex
index cd0ee466c5..b257b2eabd 100644
--- a/lib/plausible/verification/diagnostics.ex
+++ b/lib/plausible/verification/diagnostics.ex
@@ -211,11 +211,12 @@ defmodule Plausible.Verification.Diagnostics do
   def interpret(
         %__MODULE__{
           plausible_installed?: true,
-          callback_status: 0,
+          callback_status: callback_status,
           proxy_likely?: true
         },
         _url
-      ) do
+      )
+      when callback_status in [0, 500] do
     error(@errors.proxy_misconfigured)
   end