Show empty channel in imported data as (not set)
This commit is contained in:
parent
da0b9403e4
commit
81fe57d82b
|
|
@ -231,6 +231,18 @@ defmodule Plausible.Stats.Imported.SQL.Expression do
|
||||||
})
|
})
|
||||||
end
|
end
|
||||||
|
|
||||||
|
defp select_group_fields(q, "visit:channel", key, _query) do
|
||||||
|
select_merge_as(q, [i], %{
|
||||||
|
key =>
|
||||||
|
fragment(
|
||||||
|
"if(empty(?), ?, ?)",
|
||||||
|
i.channel,
|
||||||
|
@not_set,
|
||||||
|
i.channel
|
||||||
|
)
|
||||||
|
})
|
||||||
|
end
|
||||||
|
|
||||||
defp select_group_fields(q, "event:page", key, _query) do
|
defp select_group_fields(q, "event:page", key, _query) do
|
||||||
select_merge_as(q, [i], %{key => i.page, time_on_page: sum(i.time_on_page)})
|
select_merge_as(q, [i], %{key => i.page, time_on_page: sum(i.time_on_page)})
|
||||||
end
|
end
|
||||||
|
|
|
||||||
|
|
@ -381,6 +381,24 @@ defmodule PlausibleWeb.Api.StatsController.ImportedTest do
|
||||||
"totalUsers" => "1",
|
"totalUsers" => "1",
|
||||||
"screenPageViews" => "1"
|
"screenPageViews" => "1"
|
||||||
}
|
}
|
||||||
|
},
|
||||||
|
%{
|
||||||
|
dimensions: %{
|
||||||
|
"sessionManualAdContent" => "",
|
||||||
|
"sessionCampaignName" => "",
|
||||||
|
"date" => "20210101",
|
||||||
|
"sessionGoogleAdsKeyword" => "",
|
||||||
|
"sessionMedium" => "(none)",
|
||||||
|
"sessionSource" => "(direct)",
|
||||||
|
"sessionDefaultChannelGroup" => ""
|
||||||
|
},
|
||||||
|
metrics: %{
|
||||||
|
"bounces" => "1",
|
||||||
|
"userEngagementDuration" => "60",
|
||||||
|
"sessions" => "1",
|
||||||
|
"totalUsers" => "1",
|
||||||
|
"screenPageViews" => "1"
|
||||||
|
}
|
||||||
}
|
}
|
||||||
],
|
],
|
||||||
site.id,
|
site.id,
|
||||||
|
|
@ -398,6 +416,7 @@ defmodule PlausibleWeb.Api.StatsController.ImportedTest do
|
||||||
|> Enum.sort()
|
|> Enum.sort()
|
||||||
|
|
||||||
assert results == [
|
assert results == [
|
||||||
|
%{"name" => "(not set)", "visitors" => 1},
|
||||||
%{"name" => "Direct", "visitors" => 2},
|
%{"name" => "Direct", "visitors" => 2},
|
||||||
%{"name" => "Organic Search", "visitors" => 3},
|
%{"name" => "Organic Search", "visitors" => 3},
|
||||||
%{"name" => "Paid Search", "visitors" => 2}
|
%{"name" => "Paid Search", "visitors" => 2}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue