From 8eca2642b01591ccbfbee98e66181d8ad5982cd3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Lam?= Date: Tue, 13 Oct 2026 10:39:03 +0200 Subject: [PATCH 1/5] ksys, uking: move four definitions to match link order calc_ goes before leave_ in ForceSetCameraPos and InWaterSelForkASPlay, and RailRoute's dtor goes after getCheckPointName (an unnamed row there is likely its D0). BaseProcJobHandler's ctor is linked right before BaseProc's ctor, so it moves into actBaseProc.cpp, and the class moves into actBaseProc.h so that its declaration stays with its definition. (AI assisted using Claude Opus 5.5) --- .../Actor/Action/actionForceSetCameraPos.cpp | 8 +-- .../Action/actionInWaterSelForkASPlay.cpp | 8 +-- src/KingSystem/ActorSystem/CMakeLists.txt | 2 - src/KingSystem/ActorSystem/actActor.h | 1 - src/KingSystem/ActorSystem/actBaseProc.cpp | 3 +- src/KingSystem/ActorSystem/actBaseProc.h | 43 ++++++++++++++++ .../ActorSystem/actBaseProcJobHandler.cpp | 8 --- .../ActorSystem/actBaseProcJobHandler.h | 51 ------------------- src/KingSystem/ActorSystem/actBaseProcMgr.cpp | 2 +- src/KingSystem/Map/mapRail.cpp | 4 +- 10 files changed, 56 insertions(+), 74 deletions(-) delete mode 100644 src/KingSystem/ActorSystem/actBaseProcJobHandler.cpp delete mode 100644 src/KingSystem/ActorSystem/actBaseProcJobHandler.h diff --git a/src/Game/Actor/Action/actionForceSetCameraPos.cpp b/src/Game/Actor/Action/actionForceSetCameraPos.cpp index ade0b7de..61e5b345 100644 --- a/src/Game/Actor/Action/actionForceSetCameraPos.cpp +++ b/src/Game/Actor/Action/actionForceSetCameraPos.cpp @@ -14,14 +14,14 @@ void ForceSetCameraPos::enter_(ksys::act::ai::InlineParamPack* params) { ksys::act::ai::Action::enter_(params); } +void ForceSetCameraPos::calc_() { + ksys::act::ai::Action::calc_(); +} + void ForceSetCameraPos::leave_() { ksys::act::ai::Action::leave_(); } void ForceSetCameraPos::loadParams_() {} -void ForceSetCameraPos::calc_() { - ksys::act::ai::Action::calc_(); -} - } // namespace uking::action diff --git a/src/Game/Actor/Action/actionInWaterSelForkASPlay.cpp b/src/Game/Actor/Action/actionInWaterSelForkASPlay.cpp index 7296f05c..791ff4f1 100644 --- a/src/Game/Actor/Action/actionInWaterSelForkASPlay.cpp +++ b/src/Game/Actor/Action/actionInWaterSelForkASPlay.cpp @@ -14,6 +14,10 @@ void InWaterSelForkASPlay::enter_(ksys::act::ai::InlineParamPack* params) { ksys::act::ai::Action::enter_(params); } +void InWaterSelForkASPlay::calc_() { + ksys::act::ai::Action::calc_(); +} + void InWaterSelForkASPlay::leave_() { ksys::act::ai::Action::leave_(); } @@ -28,8 +32,4 @@ void InWaterSelForkASPlay::loadParams_() { getStaticParam(&mASName_s, "ASName"); } -void InWaterSelForkASPlay::calc_() { - ksys::act::ai::Action::calc_(); -} - } // namespace uking::action diff --git a/src/KingSystem/ActorSystem/CMakeLists.txt b/src/KingSystem/ActorSystem/CMakeLists.txt index e0b70bfd..71080f19 100644 --- a/src/KingSystem/ActorSystem/CMakeLists.txt +++ b/src/KingSystem/ActorSystem/CMakeLists.txt @@ -77,8 +77,6 @@ target_sources(uking PRIVATE actBaseProcInitializer.h actBaseProcJob.cpp actBaseProcJob.h - actBaseProcJobHandler.cpp - actBaseProcJobHandler.h actBaseProcJobQue.cpp actBaseProcJobQue.h actBaseProcLink.cpp diff --git a/src/KingSystem/ActorSystem/actActor.h b/src/KingSystem/ActorSystem/actActor.h index 2749d091..dcd0515d 100644 --- a/src/KingSystem/ActorSystem/actActor.h +++ b/src/KingSystem/ActorSystem/actActor.h @@ -11,7 +11,6 @@ #include #include "KingSystem/ActorSystem/actActorEditorNode.h" #include "KingSystem/ActorSystem/actBaseProc.h" -#include "KingSystem/ActorSystem/actBaseProcJobHandler.h" #include "KingSystem/ActorSystem/actBaseProcLink.h" #include "KingSystem/ActorSystem/actPhysicsConstraints.h" #include "KingSystem/ActorSystem/actPhysicsUserTag.h" diff --git a/src/KingSystem/ActorSystem/actBaseProc.cpp b/src/KingSystem/ActorSystem/actBaseProc.cpp index cce31c21..97b1b5b1 100644 --- a/src/KingSystem/ActorSystem/actBaseProc.cpp +++ b/src/KingSystem/ActorSystem/actBaseProc.cpp @@ -3,7 +3,6 @@ #include