mirror/botw
1
0
Fork 0
mirror of https://github.com/zeldaret/botw synced 2026-05-26 23:47:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Add #ifdef declarations for NON_MATCHING code"

Browse Source 
This reverts commit 42807160cf.

It makes searching for NON_MATCHING comment descriptions much less
convenient in most text editors or IDEs, and we want the function
CSV to be the single source of truth for function statuses. Having
a function marked as matching but not built because of a stray #ifdef
would be bad.
This commit is contained in:
Léo Lam
2022-02-27 12:48:28 +01:00
parent a564186002
commit df36d65665
52 changed files with 93 additions and 257 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/KingSystem/Utils/Thread/TaskQueueBase.cpp
+2 -6
View File
@@ -234,8 +234,7 @@ void TaskQueueBase::blockTasks(u8 id) {
mLanes[id].blocked = true;
}
// the while (!areAllThreadsPaused()) loop generates weird code in the original
#ifdef NON_MATCHING
// NON_MATCHING: the while (!areAllThreadsPaused()) loop generates weird code in the original
void TaskQueueBase::blockTasksAndReloadThreads(u8 id) {
blockTasks(id);
@@ -258,7 +257,6 @@ void TaskQueueBase::blockTasksAndReloadThreads(u8 id) {
thread.resume();
}
}
#endif
void TaskQueueBase::unblockTasks(u8 id) {
if (mLanes[id].blocked) {
@@ -409,8 +407,7 @@ void TaskQueueBase::removeTask(Task* task, bool b) {
unlock();
}
// regalloc inside the task lambda + reorderings for the loop counters.
#ifdef NON_MATCHING
// NON_MATCHING: regalloc inside the task lambda + reorderings for the loop counters.
void TaskQueueBase::fetchTask(Task** out_task) {
lock();
@@ -484,6 +481,5 @@ void TaskQueueBase::fetchTask(Task** out_task) {
unlock();
}
#endif
} // namespace ksys::util