From 3520bb746cb62a8764d7be58c22cb679ce5e5e42 Mon Sep 17 00:00:00 2001 From: qwertyquerty Date: Thu, 14 May 2026 13:56:15 -0700 Subject: [PATCH] better completionist achievement requirements for skybook (#1258) --- src/dusk/achievements.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/dusk/achievements.cpp b/src/dusk/achievements.cpp index def7cd97ad..a8e4ff3916 100644 --- a/src/dusk/achievements.cpp +++ b/src/dusk/achievements.cpp @@ -191,13 +191,17 @@ std::vector AchievementSystem::makeEntries() { } bool hasJewelRod = false; - for (int slot = 0; slot < 24 && !hasJewelRod; ++slot) { + bool hasAncientDoc = false; + for (int slot = 0; slot < 24; ++slot) { const u8 item = dComIfGs_getItem(slot, false); if (item == dItemNo_JEWEL_ROD_e || item == dItemNo_JEWEL_BEE_ROD_e || item == dItemNo_JEWEL_WORM_ROD_e) { hasJewelRod = true; } + if (item == dItemNo_ANCIENT_DOCUMENT_e || item == dItemNo_ANCIENT_DOCUMENT2_e || item == dItemNo_AIR_LETTER_e) { + hasAncientDoc = true; + } } - if (!hasJewelRod) { + if (!hasJewelRod || !hasAncientDoc) { return; } @@ -212,7 +216,6 @@ std::vector AchievementSystem::makeEntries() { dItemNo_KANTERA_e, dItemNo_PACHINKO_e, dItemNo_HAWK_EYE_e, - dItemNo_ANCIENT_DOCUMENT_e, dItemNo_HORSE_FLUTE_e, }; for (u8 required : requiredWheelItems) {