From 701e075698d3bcafca7604a586b71e307cee6336 Mon Sep 17 00:00:00 2001
From: Luke Street <luke@street.dev>
Date: Wed, 16 Sep 2026 22:43:18 -0600
Subject: [PATCH] Fix SelectButton key/value truncation

Fixes #2454
---
 res/rml/window.rcss           | 27 ++++++++++++++++++++-------
 src/dusk/ui/select_button.cpp |  1 +
 2 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/res/rml/window.rcss b/res/rml/window.rcss
index f820de9735..a819151ac7 100644
--- a/res/rml/window.rcss
+++ b/res/rml/window.rcss
@@ -333,21 +333,24 @@ select-button:disabled {
     cursor: default;
 }
 
+select-button key,
+select-button value {
+    min-width: 0;
+    overflow: hidden;
+    text-overflow: ellipsis;
+    white-space: nowrap;
+}
+
 select-button key {
     font-family: var(--font-family-heading);
     font-weight: bold;
     font-size: var(--font-size-xl);
     text-transform: uppercase;
-    flex: 0 0 auto;
-    white-space: nowrap;
+    flex: 0 1 auto;
 }
 
 select-button value {
-    flex: 1 1 auto;
-    min-width: 0;
-    overflow: hidden;
-    text-overflow: ellipsis;
-    white-space: nowrap;
+    flex: 1 0 20%;
     text-align: right;
     font-size: var(--font-size-2xl);
 }
@@ -361,6 +364,16 @@ select-button input {
     font-size: var(--font-size-2xl);
 }
 
+select-button icon {
+    display: none;
+    flex: 0 0 auto;
+}
+
+select-button.has-icon icon,
+select-button.group-button icon {
+    display: inline-block;
+}
+
 select-button.group-button icon {
     flex: 0 0 24dp;
     margin-left: auto;
diff --git a/src/dusk/ui/select_button.cpp b/src/dusk/ui/select_button.cpp
index 39769f533f..7f50321da7 100644
--- a/src/dusk/ui/select_button.cpp
+++ b/src/dusk/ui/select_button.cpp
@@ -80,6 +80,7 @@ void SelectButton::update_props(Props props) {
         if (!props.icon.empty()) {
             mIconElem->SetClass(props.icon, true);
         }
+        mRoot->SetClass("has-icon", !props.icon.empty());
     }
     set_value_label(props.value);
     set_modified(props.modified);