Clean up code, remove fakematches, add UNUSED, enable warnings (#2992)

* Remove NDEBUG_DEFINED fakematch, clean up getName temps

* Fix ifdef

* Fix bad JSystem pch ifdef breaking decomp.me

* Remove Acch Chk fakematches

* Private Acch fields

* Fix some clangd errors in headers

* Add UNUSED macro for matching debug parameters

* Enable clangd unused-parameter warning

* Remove extern from initializers

Probably added by dol2asm?

* Fix process profile definitions

* Remove leftover dol2asm address comments

* Remove some unnecessary double casts

* Enable some more clangd warnings

* Fix missing usages of fopAcM_ct

* Fix wrong enum usage

* Fix more fakematches
This commit is contained in:
LagoLunatic
2025-12-23 18:53:10 -05:00
committed by GitHub
parent 6ef13c620a
commit 877889c510
887 changed files with 1174 additions and 1727 deletions
+7 -3
View File
@@ -1740,8 +1740,12 @@ void daKago_c::initPerchDemo() {
}
cXyz cStack_54 = dPath_GetPnt(mpPath2, local_80)->m_position;
s16 temp = (s16)sVar5 - cLib_targetAngleY(&current.pos, &cStack_48);
sVar5 = temp < 0 ? (s16)((s16)sVar5 - 0x1000) : (s16)((s16)sVar5 + 0x1000); // fakematch
s16 sp08 = cLib_targetAngleY(&current.pos, &cStack_48);
if ((s16)(sVar5 - sp08) < 0) {
sVar5 = sVar5 - 0x1000;
} else {
sVar5 = sVar5 + 0x1000;
}
shape_angle.y = current.angle.y = sVar5;
shape_angle.x = shape_angle.z = 0;
@@ -3892,7 +3896,7 @@ static actor_method_class l_daKago_Method = {
(process_method_func)daKago_Draw,
};
extern actor_process_profile_definition g_profile_KAGO = {
actor_process_profile_definition g_profile_KAGO = {
fpcLy_CURRENT_e, // mLayerID
4, // mListID
fpcPi_CURRENT_e, // mListPrio