Clean up code, remove fakematches, add UNUSED, enable warnings (#2992)

* Remove NDEBUG_DEFINED fakematch, clean up getName temps

* Fix ifdef

* Fix bad JSystem pch ifdef breaking decomp.me

* Remove Acch Chk fakematches

* Private Acch fields

* Fix some clangd errors in headers

* Add UNUSED macro for matching debug parameters

* Enable clangd unused-parameter warning

* Remove extern from initializers

Probably added by dol2asm?

* Fix process profile definitions

* Remove leftover dol2asm address comments

* Remove some unnecessary double casts

* Enable some more clangd warnings

* Fix missing usages of fopAcM_ct

* Fix wrong enum usage

* Fix more fakematches
This commit is contained in:
LagoLunatic
2025-12-23 18:53:10 -05:00
committed by GitHub
parent 6ef13c620a
commit 877889c510
887 changed files with 1174 additions and 1727 deletions
+2 -5
View File
@@ -2660,10 +2660,7 @@ inline f32 CylH(int type) {
}
cPhs__Step daNpcChat_c::Create() {
if (!fopAcM_CheckCondition(this, fopAcCnd_INIT_e)) {
new (this) daNpcChat_c();
fopAcM_OnCondition(this, fopAcCnd_INIT_e);
}
fopAcM_ct(this, daNpcChat_c);
mTwilight = dKy_darkworld_check();
mType = getType();
@@ -4128,7 +4125,7 @@ static actor_method_class daNpcChat_MethodTable = {
(process_method_func)daNpcChat_Draw,
};
extern actor_process_profile_definition g_profile_NPC_CHAT = {
actor_process_profile_definition g_profile_NPC_CHAT = {
fpcLy_CURRENT_e, // mLayerID
7, // mListID
fpcPi_CURRENT_e, // mListPrio