Clean up code, remove fakematches, add UNUSED, enable warnings (#2992)

* Remove NDEBUG_DEFINED fakematch, clean up getName temps

* Fix ifdef

* Fix bad JSystem pch ifdef breaking decomp.me

* Remove Acch Chk fakematches

* Private Acch fields

* Fix some clangd errors in headers

* Add UNUSED macro for matching debug parameters

* Enable clangd unused-parameter warning

* Remove extern from initializers

Probably added by dol2asm?

* Fix process profile definitions

* Remove leftover dol2asm address comments

* Remove some unnecessary double casts

* Enable some more clangd warnings

* Fix missing usages of fopAcM_ct

* Fix wrong enum usage

* Fix more fakematches
This commit is contained in:
LagoLunatic
2025-12-23 18:53:10 -05:00
committed by GitHub
parent 6ef13c620a
commit 877889c510
887 changed files with 1174 additions and 1727 deletions
+2 -2
View File
@@ -299,7 +299,7 @@ void daNpcImpal_c::setExpressionTalkAfter() {
int daNpcImpal_c::step(s16 i_angle, int i_animate) {
if (mTurnMode == 0) {
if (i_animate) {
if ((s32)fabsf(cM_sht2d((f32)(s16)(i_angle - mCurAngle.y))) > 40) {
if ((s32)fabsf(cM_sht2d((s16)(i_angle - mCurAngle.y))) > 40) {
setExpression(EXPR_7, -1.0f);
setMotion(MOT_6, -1.0f, false);
}
@@ -1236,7 +1236,7 @@ static actor_method_class daNpcImpal_MethodTable = {
(process_method_func)daNpcImpal_Draw,
};
extern actor_process_profile_definition g_profile_NPC_IMPAL = {
actor_process_profile_definition g_profile_NPC_IMPAL = {
fpcLy_CURRENT_e, // mLayerID
7, // mListID
fpcPi_CURRENT_e, // mListPrio