Clean up code, remove fakematches, add UNUSED, enable warnings (#2992)

* Remove NDEBUG_DEFINED fakematch, clean up getName temps

* Fix ifdef

* Fix bad JSystem pch ifdef breaking decomp.me

* Remove Acch Chk fakematches

* Private Acch fields

* Fix some clangd errors in headers

* Add UNUSED macro for matching debug parameters

* Enable clangd unused-parameter warning

* Remove extern from initializers

Probably added by dol2asm?

* Fix process profile definitions

* Remove leftover dol2asm address comments

* Remove some unnecessary double casts

* Enable some more clangd warnings

* Fix missing usages of fopAcM_ct

* Fix wrong enum usage

* Fix more fakematches
This commit is contained in:
LagoLunatic
2025-12-23 18:53:10 -05:00
committed by GitHub
parent 6ef13c620a
commit 877889c510
887 changed files with 1174 additions and 1727 deletions
+3 -3
View File
@@ -643,7 +643,7 @@ int daObjMovebox::Act_c::CreateHeap() {
}
void daObjMovebox::Act_c::RideCallBack(dBgW* i_bgw, fopAc_ac_c* i_actor, fopAc_ac_c* i_rideActor) {
(void)i_bgw;
UNUSED(i_bgw);
Act_c* a_this = (Act_c*)i_actor;
if (a_this->field_0x5ac == 2) {
@@ -697,7 +697,7 @@ enum MOVE_DIR {
fopAc_ac_c* daObjMovebox::Act_c::PPCallBack(fopAc_ac_c* i_bgActor, fopAc_ac_c* i_pushActor,
s16 i_angle, dBgW_Base::PushPullLabel pp_label) {
(void)i_pushActor;
UNUSED(i_pushActor);
dBgW::PushPullLabel var_r26 = cLib_checkBit<dBgW::PushPullLabel>(
pp_label, (dBgW::PushPullLabel)(dBgW::PPLABEL_PUSH | dBgW::PPLABEL_PULL));
@@ -1410,7 +1410,7 @@ static actor_method_class Mthd_Table = {
}; // namespace
}; // namespace daObjMovebox
extern actor_process_profile_definition g_profile_Obj_Movebox = {
actor_process_profile_definition g_profile_Obj_Movebox = {
fpcLy_CURRENT_e, // mLayerID
3, // mListID
fpcPi_CURRENT_e, // mListPrio