Clean up code, remove fakematches, add UNUSED, enable warnings (#2992)

* Remove NDEBUG_DEFINED fakematch, clean up getName temps

* Fix ifdef

* Fix bad JSystem pch ifdef breaking decomp.me

* Remove Acch Chk fakematches

* Private Acch fields

* Fix some clangd errors in headers

* Add UNUSED macro for matching debug parameters

* Enable clangd unused-parameter warning

* Remove extern from initializers

Probably added by dol2asm?

* Fix process profile definitions

* Remove leftover dol2asm address comments

* Remove some unnecessary double casts

* Enable some more clangd warnings

* Fix missing usages of fopAcM_ct

* Fix wrong enum usage

* Fix more fakematches
This commit is contained in:
LagoLunatic
2025-12-23 18:53:10 -05:00
committed by GitHub
parent 6ef13c620a
commit 877889c510
887 changed files with 1174 additions and 1727 deletions
+1 -8
View File
@@ -67,7 +67,6 @@ void daObjNameplate_c::setBaseMtx() {
}
void daObjNameplate_c::initCcSphere() {
/* 80594EB4-80594EF4 000040 0040+00 1/1 0/0 0/0 .rodata ccSphSrc$3700 */
const static dCcD_SrcSph ccSphSrc = {
{
{0x0, {{0x0, 0x0, 0x0}, {0x1607a, 0x11}, 0x99}}, // mObj
@@ -263,9 +262,6 @@ static int daObjNameplate_Draw(daObjNameplate_c* i_this) {
return i_this->draw();
}
/* 80594A6C-80594AB4 000A4C 0048+00 1/0 0/0 0/0 .text
* daObjNameplate_Execute__FP16daObjNameplate_c
*/
static int daObjNameplate_Execute(daObjNameplate_c* i_this) {
i_this->calcAngle();
i_this->setBaseMtx();
@@ -279,9 +275,6 @@ static int daObjNameplate_IsDelete(daObjNameplate_c* i_this) {
return 1;
}
/* 80594ABC-80594BF8 000A9C 013C+00 1/0 0/0 0/0 .text
* daObjNameplate_Delete__FP16daObjNameplate_c
*/
static int daObjNameplate_Delete(daObjNameplate_c* i_this) {
i_this->~daObjNameplate_c();
return 1;
@@ -314,7 +307,7 @@ static actor_method_class l_daObjNameplate_Method = {
(process_method_func)daObjNameplate_Draw,
};
extern actor_process_profile_definition g_profile_Obj_NamePlate = {
actor_process_profile_definition g_profile_Obj_NamePlate = {
fpcLy_CURRENT_e, // mLayerID
7, // mListID
fpcPi_CURRENT_e, // mListPrio