Clean up code, remove fakematches, add UNUSED, enable warnings (#2992)

* Remove NDEBUG_DEFINED fakematch, clean up getName temps

* Fix ifdef

* Fix bad JSystem pch ifdef breaking decomp.me

* Remove Acch Chk fakematches

* Private Acch fields

* Fix some clangd errors in headers

* Add UNUSED macro for matching debug parameters

* Enable clangd unused-parameter warning

* Remove extern from initializers

Probably added by dol2asm?

* Fix process profile definitions

* Remove leftover dol2asm address comments

* Remove some unnecessary double casts

* Enable some more clangd warnings

* Fix missing usages of fopAcM_ct

* Fix wrong enum usage

* Fix more fakematches
This commit is contained in:
LagoLunatic
2025-12-23 18:53:10 -05:00
committed by GitHub
parent 6ef13c620a
commit 877889c510
887 changed files with 1174 additions and 1727 deletions
+2 -3
View File
@@ -180,7 +180,6 @@ static int daVrbox2_Draw(vrbox2_class* i_this) {
if (strcmp(dComIfGp_getStartStageName(), "F_SP127") == 0) {
/* 80499B78-80499B7C 000000 0002+02 1/1 0/0 0/0 .bss mangZ$3688 */
static s16 mangZ;
sp14 = sun_p->mPos[0];
@@ -387,7 +386,7 @@ static int daVrbox2_color_set(vrbox2_class* i_this) {
}
static int daVrbox2_Execute(vrbox2_class* i_this) {
i_this = i_this; // ?? fakematch? only needed for debug
UNUSED(i_this);
if (g_env_light.daytime > 255.0f) {
i_this->mSunBtk.play();
@@ -454,7 +453,7 @@ static actor_method_class l_daVrbox2_Method = {
(process_method_func)daVrbox2_Draw,
};
extern actor_process_profile_definition g_profile_VRBOX2 = {
actor_process_profile_definition g_profile_VRBOX2 = {
fpcLy_CURRENT_e,
7,
fpcPi_CURRENT_e,