mirror/dusklight
1
0
Fork 0
mirror of https://github.com/TwilitRealm/dusklight synced 2026-08-01 07:57:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Start linking some TUs on debug and PAL (#2612)

Browse Source 
* Fix clang union handling (affects all TUs including d_camera.h)

Union members with non-trivial ctors/dtors is undefined behavior and clangd normally throws a fit and refuses to parse the whole union, but it seems to be possible to ifdef the problematic ctors out for non-mwerks compilers and explicitly tell modern compilers to use the defaults instead. Thanks to encounter for this fix.

* Link all TUs that already match on debug

In order to link TUs for debug, most functions seem to need to have their alignment set to 16 in symbols.txt. There are a few hundred functions that seem to be the exception and break when their alignment is set to 16, but I don't know the reason for this.

* Remove some fakematches (nosyminline/sym off) for weak func order in retail

* Fix clang not knowing that MSL_C++ is C++

* Link more debug TUs

* Fix missing PAL split

* Fix wrong slashes being used in includes

* RZDE01_00: Fix incorrect capitalization in config.yml

* Add RZDE01_00 to configure task

* Revert configure.py to use MatchingFor

* Fix PAL splits and symbols, link matching PAL TUs
This commit is contained in:
LagoLunatic
2025-08-27 20:37:31 -04:00
committed by GitHub
parent 561c9258f0
commit aed8fe8cd3
652 changed files with 34508 additions and 34453 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/JSystem/JFramework/JFWSystem.cpp
+1 -1
View File
@@ -87,7 +87,7 @@ JUTConsoleManager* JFWSystem::systemConsoleManager;
JUTConsole* JFWSystem::systemConsole;
/* 804511BC-804511C0 0006BC 0004+00 1/1 0/0 0/0 .sbss None */
static u8 sInitCalled;
bool JFWSystem::sInitCalled = false;
/* 80271D18-80272040 26C658 0328+00 0/0 1/1 0/0 .text init__9JFWSystemFv */
// NONMATCHING - regalloc, equivalent
src/JSystem/JStage/JSGCamera.cpp
+3 -2
View File
@@ -1,5 +1,6 @@
#include "JSystem/JStage/JSGCamera.h"
#include "math.h"
#include "limits.h"
/* 80280BA0-80280C00 27B4E0 0060+00 0/0 1/1 0/0 .text __dt__Q26JStage7TCameraFv */
JStage::TCamera::~TCamera() {}
@@ -31,7 +32,7 @@ void JStage::TCamera::JSGSetProjectionNear(f32) {}
/* 80280C20-80280C2C 27B560 000C+00 1/0 0/0 0/0 .text JSGGetProjectionFar__Q26JStage7TCameraCFv */
f32 JStage::TCamera::JSGGetProjectionFar() const {
return FLT_MAX;
return std::numeric_limits<f32>::max();
}
/* 80280C2C-80280C30 27B56C 0004+00 1/0 0/0 0/0 .text JSGSetProjectionFar__Q26JStage7TCameraFf */
@@ -104,4 +105,4 @@ f32 JStage::TCamera::JSGGetViewRoll() const {
/* 80280C7C-80280C80 27B5BC 0004+00 1/0 0/0 0/0 .text JSGSetViewRoll__Q26JStage7TCameraFf
*/
void JStage::TCamera::JSGSetViewRoll(f32) {}
void JStage::TCamera::JSGSetViewRoll(f32) {}