Clean up code, remove fakematches, add UNUSED, enable warnings (#2992)

* Remove NDEBUG_DEFINED fakematch, clean up getName temps

* Fix ifdef

* Fix bad JSystem pch ifdef breaking decomp.me

* Remove Acch Chk fakematches

* Private Acch fields

* Fix some clangd errors in headers

* Add UNUSED macro for matching debug parameters

* Enable clangd unused-parameter warning

* Remove extern from initializers

Probably added by dol2asm?

* Fix process profile definitions

* Remove leftover dol2asm address comments

* Remove some unnecessary double casts

* Enable some more clangd warnings

* Fix missing usages of fopAcM_ct

* Fix wrong enum usage

* Fix more fakematches
This commit is contained in:
LagoLunatic
2025-12-23 18:53:10 -05:00
committed by GitHub
parent 889dc157ab
commit e8c70fb18f
887 changed files with 1174 additions and 1727 deletions
+1 -7
View File
@@ -100,32 +100,26 @@ bool daObjTimer::Act_c::_execute() {
namespace daObjTimer {
namespace {
/* 804855A4-804855C0 .text daObjTimer::@unnamed@d_a_obj_timer_cpp@::Mthd_Create */
int Mthd_Create(void* i_this) {
return static_cast<daObjTimer::Act_c*>(i_this)->_create();
}
/* 804855C4-804855E4 .text daObjTimer::@unnamed@d_a_obj_timer_cpp@::Mthd_Delete */
int Mthd_Delete(void* i_this) {
return static_cast<daObjTimer::Act_c*>(i_this)->_delete();
}
/* 804855E8-80485608 .text daObjTimer::@unnamed@d_a_obj_timer_cpp@::Mthd_Execute */
int Mthd_Execute(void* i_this) {
return static_cast<daObjTimer::Act_c*>(i_this)->_execute();
}
/* 8048560C-80485610 .text daObjTimer::@unnamed@d_a_obj_timer_cpp@::Mthd_Draw */
int Mthd_Draw(void* i_this) {
return 1;
}
/* 80485614-80485618 .text daObjTimer::@unnamed@d_a_obj_timer_cpp@::Mthd_IsDelete */
int Mthd_IsDelete(void* i_this) {
return 1;
}
/* 80485698-804856B8 -00001 0020+00 1/0 0/0 0/0 .data Mthd_Table__Q210daObjTimer27@unnamed@d_a_obj_timer_cpp@ */
actor_method_class l_daTimer_Method = {
(process_method_func)Mthd_Create,
(process_method_func)Mthd_Delete,
@@ -137,7 +131,7 @@ namespace {
}; // namespace daObjTimer
extern actor_process_profile_definition g_profile_Obj_Timer = {
actor_process_profile_definition g_profile_Obj_Timer = {
fpcLy_CURRENT_e, // mLayerID
10, // mListID
fpcPi_CURRENT_e, // mListPrio