Clean up code, remove fakematches, add UNUSED, enable warnings (#2992)

* Remove NDEBUG_DEFINED fakematch, clean up getName temps

* Fix ifdef

* Fix bad JSystem pch ifdef breaking decomp.me

* Remove Acch Chk fakematches

* Private Acch fields

* Fix some clangd errors in headers

* Add UNUSED macro for matching debug parameters

* Enable clangd unused-parameter warning

* Remove extern from initializers

Probably added by dol2asm?

* Fix process profile definitions

* Remove leftover dol2asm address comments

* Remove some unnecessary double casts

* Enable some more clangd warnings

* Fix missing usages of fopAcM_ct

* Fix wrong enum usage

* Fix more fakematches
This commit is contained in:
LagoLunatic
2025-12-23 18:53:10 -05:00
committed by GitHub
parent 889dc157ab
commit e8c70fb18f
887 changed files with 1174 additions and 1727 deletions
+5 -7
View File
@@ -598,15 +598,13 @@ void daObjVolcBom_c::actionWait() {
}
daMidna_c* midna = daPy_py_c::getMidnaActor();
daPy_py_c* player = (daPy_py_c*)daPy_getPlayerActorClass();
daPy_py_c* player = daPy_getPlayerActorClass();
// Probably fake match since ebug calls different manager functions
dEvent_manager_c& evtMgr = g_dComIfG_gameInfo.play.getEvtManager();
if (evtMgr.startCheck(mEventId)) {
if (strcmp(evtMgr.getRunEventName(), "PORTAL_WARP_BIGVOLC") == 0) {
if (dComIfGp_evmng_startCheck(mEventId)) {
if (strcmp(dComIfGp_getEventManager().getRunEventName(), "PORTAL_WARP_BIGVOLC") == 0) {
player->onWarpObjDemo();
dComIfGp_getEvent().setPt2(this);
mStaffId = evtMgr.getMyStaffId(l_staff_name, 0, 0);
mStaffId = dComIfGp_evmng_getMyStaffId(l_staff_name, 0, 0);
setAction(ACTION_WARP_EVENT);
demoProc();
}
@@ -882,7 +880,7 @@ static actor_method_class daObjVolcBom_METHODS = {
(process_method_func)daObjVolcBom_MoveBGDraw,
};
extern actor_process_profile_definition g_profile_Obj_VolcanicBomb = {
actor_process_profile_definition g_profile_Obj_VolcanicBomb = {
fpcLy_CURRENT_e, // mLayerID
3, // mListID
fpcPi_CURRENT_e, // mListPrio