eden/src/hid_core at e63b248e54befb40a217aa7344b2a6cc95b05bd4 - eden

mirror of https://git.eden-emu.dev/eden-emu/eden synced 2026-10-09 21:44:02 -04:00

Files

T

BoiledElectricity 470d43df6d [hid_core] fix bounds-check aruid index in GetControllerFromNpadIdType (#4064 )

GetIndexFromAruid returns AruidIndexMax as the “not found” value, but both
GetControllerFromNpadIdType overloads were using that value to index
controller_data without checking it first.

when a game routes through DisconnectNpad before its applet resource is
registered, we can end up indexing past the end of controller_data. That seems
to be what was crashing some games on launch, especially on macOS and Android,
where the out-of-bounds read is less likely to just slide by unnoticed.

So yeah, AruidIndexMax is a sentinel, not a real controller_data index, so we
should not treat it like one.

  Fixes: https://github.com/eden-emulator/Issue-Reports/issues/438
  Fixes: https://github.com/eden-emulator/Issue-Reports/issues/439

Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4064
Reviewed-by: Lizzie <lizzie@eden-emu.dev>
Reviewed-by: MaranBr <maranbr@eden-emu.dev>

2026-06-05 19:26:21 +02:00

frontend

[*] basic in-house cpp linting (#4039 )

2026-06-04 05:49:07 +02:00

hidbus

[meta] fix license headers (#2547 )

2025-09-21 21:58:59 +02:00

irsensor

[meta] fix license headers (#2547 )

2025-09-21 21:58:59 +02:00

resources

[hid_core] fix bounds-check aruid index in GetControllerFromNpadIdType (#4064 )