mirror
/
edit
mirror of https://github.com/microsoft/edit
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix lines_bwd unit test (#574) 

The implementation is correct, and the test was wrong.
TTD fans in shambles rn.

Closes #566
This commit is contained in:
Leonard Hecker 2025-07-10 00:31:52 +02:00 committed by GitHub
parent 2f48091708
commit 63d2574774
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/simd/lines_bwd.rs
View File

@ -109,7 +109,6 @@ unsafe fn lines_bwd_avx2(
}
let lf = _mm256_set1_epi8(b'\n' as i8);
let line_stop = line_stop.min(line);
let off = end.addr() & 31;
if off != 0 && off < end.offset_from_unsigned(beg) {
(end, line) = lines_bwd_fallback(end.sub(off), end, line, line_stop);
@ -414,7 +413,7 @@ mod test {
for _ in 0..1000 {
let offset = offset_rng() % (text.len() + 1);
let line_stop = line_distance_rng() % (lines + 1);
let line = line_stop + line_rng() % 100;
let line = (line_stop + line_rng() % 100).saturating_sub(5);
let line = line as CoordType;
let line_stop = line_stop as CoordType;
@ -432,20 +431,19 @@ mod test {
mut line: CoordType,
line_stop: CoordType,
) -> (usize, CoordType) {
if line >= line_stop {
while offset > 0 {
let c = haystack[offset - 1];
if c == b'\n' {
if line == line_stop {
break;
}
line -= 1;
while offset > 0 {
let c = haystack[offset - 1];
if c == b'\n' {
if line <= line_stop {
break;
}
offset -= 1;
line -= 1;
}
offset -= 1;
}
(offset, line)
}
#[test]
fn seeks_to_start() {
for i in 6..=11 {

2
src/simd/lines_fwd.rs
View File

@ -416,7 +416,7 @@ mod test {
for _ in 0..1000 {
let offset = offset_rng() % (text.len() + 1);
let line = line_rng() % 100;
let line_stop = line + line_distance_rng() % (lines + 1);
let line_stop = (line + line_distance_rng() % (lines + 1)).saturating_sub(5);
let line = line as CoordType;
let line_stop = line_stop as CoordType;