3 Commits

Author SHA1 Message Date
bryanthaboi ebbf4709c8 CLOSES #2411, CLOSES #2418, CLOSES #2420, CLOSES #2422, CLOSES #2423, CLOSES #2424 2026-09-23 05:51:05 -04:00
thibautbus f8fbe53346 Show a FireRed egg as an egg on the PC panel, summary and trade screens
Three screens that show a single mon still drew an egg as the species it
will hatch into, and printed its stored nickname untranslated:

- The PC's hovered-mon panel drew the hatch species' front pic, the stored
  "EGG" nickname, "/PICHU", gender, level and held item. pret draws the
  SPECIES_OR_EGG pic and, for an egg, prints only gText_EggNickname with the
  other lines blank (pokemon_storage_system_data.c:1034, :1091).
- The summary's egg page drew the hatch species' front pic, where pret uses
  SPECIES_OR_EGG (pokemon_summary_screen.c:4016). It also recognised an egg by
  mon.isEgg alone; it now uses Pokemon.isEgg like the rest of the engine.
- The trade scene drew a traded egg as its species and named it by the stored
  nickname (trade_scene.c:757, :1239).

The script string buffers (BufferMonNickname and the other nicknameOf
helpers) now also give the language's EGG for an egg, as GetMonData
(MON_DATA_NICKNAME) does (pokemon.c:3020).
2026-09-22 12:10:44 +02:00
thibautbus aaacf02dc0 Draw a FireRed egg's menu icon as an egg
The party, the PC boxes and the release animation drew an egg with the icon
of the species it will hatch into, so a Pichu egg showed as a Pichu. pret's
party menu picks the icon from GetMonData(MON_DATA_SPECIES_OR_EGG), which is
SPECIES_EGG for any egg (pokefirered/src/pokemon.c:3245, party_menu.c:2655).

Pokemon.speciesOrEgg does the same, and the icon call sites use it. The
species pass only extracted icons up to NUM_SPECIES - 1, so the egg extractor
now also bakes gMonIconTable[SPECIES_EGG] as pokemon/icons/412.rgba. Cache
version 114 re-imports existing caches so the icon appears.
2026-09-22 12:10:44 +02:00