mirror
/
hurl
mirror of https://github.com/Orange-OpenSource/hurl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Run clippy on all targets.

This commit is contained in:
Jean-Christophe Amiel 2025-01-29 18:00:13 +01:00
parent bc96085f39
commit 3d39ff0d5d
No known key found for this signature in database
GPG Key ID: 07FF11CFD55356CC
9 changed files with 27 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bin/check/clippy.sh
View File

@ -1,3 +1,4 @@
#!/bin/bash
set -Eeuo pipefail
cargo clippy
cargo clippy --all-targets

4
packages/hurl/src/http/client.rs
View File

@ -1196,7 +1196,7 @@ mod tests {
let logger_options = LoggerOptionsBuilder::default().build();
let stderr = Stderr::new(WriteMode::Immediate);
let mut logger = Logger::new(&logger_options, stderr, &vec![]);
let mut logger = Logger::new(&logger_options, stderr, &[]);
let cmd = client.curl_command_line(&request, &context_dir, output, &options, &mut logger);
assert_eq!(
@ -1261,6 +1261,6 @@ mod tests {
assert_eq!(
list.iter().collect::<Vec<_>>(),
vec!["foo: a".as_bytes(), "bar: b".as_bytes(), "baz;".as_bytes()]
)
);
}
}

30
packages/hurl/src/http/curl_cmd.rs
View File

@ -543,12 +543,12 @@ mod tests {
let options = ClientOptions::default();
let output = None;
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(cmd.to_string(), "curl 'http://localhost:8000/hello'");
// Same requests with some output:
let output = Some(Output::new("foo.out"));
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl \
@ -561,7 +561,7 @@ mod tests {
headers.push(Header::new("User-Agent", "iPhone"));
headers.push(Header::new("Foo", "Bar"));
request.headers = headers;
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl \
@ -594,7 +594,7 @@ mod tests {
http_only: true,
},
];
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl \
@ -657,7 +657,7 @@ mod tests {
verbosity: None,
};
let cmd = CurlCmd::new(&request, &cookies, &context_dir, None, &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, None, &options);
assert_eq!(
cmd.to_string(),
"curl \
@ -701,7 +701,7 @@ mod tests {
let options = ClientOptions::default();
let output = None;
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl 'https://example.org/hello/../to/../your/../file'"
@ -721,7 +721,7 @@ mod tests {
let options = ClientOptions::default();
let output = None;
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl \
@ -753,7 +753,7 @@ mod tests {
let options = ClientOptions::default();
let output = None;
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl 'http://localhost:8000/querystring-params?param1=value1&param2=a%20b'",
@ -763,7 +763,7 @@ mod tests {
request.url =
Url::from_str("http://localhost:8000/querystring-params?param3=foo&param4=bar")
.unwrap();
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl 'http://localhost:8000/querystring-params?param3=foo&param4=bar&param1=value1&param2=a%20b'",
@ -792,7 +792,7 @@ mod tests {
let options = ClientOptions::default();
let output = None;
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl \
@ -811,7 +811,7 @@ mod tests {
method: Method("POST".to_string()),
url: Url::from_str("http://localhost/json").unwrap(),
headers,
body: Body::Text("".to_string()),
body: Body::Text(String::new()),
implicit_content_type: Some("application/json".to_string()),
..Default::default()
};
@ -821,7 +821,7 @@ mod tests {
let options = ClientOptions::default();
let output = None;
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl \
@ -832,7 +832,7 @@ mod tests {
// Add a non-empty body
request.body = Body::Text("{\"foo\":\"bar\"}".to_string());
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl \
@ -843,7 +843,7 @@ mod tests {
// Change method
request.method = Method("PUT".to_string());
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl \
@ -868,7 +868,7 @@ mod tests {
let options = ClientOptions::default();
let output = None;
let cmd = CurlCmd::new(&request, &cookies, &context_dir, output.as_ref(), &options);
let cmd = CurlCmd::new(&request, &cookies, context_dir, output.as_ref(), &options);
assert_eq!(
cmd.to_string(),
"curl \

3
packages/hurl/src/http/tests/mod.rs
View File

@ -15,14 +15,13 @@
* limitations under the License.
*
*/
//! Some [`Request`]/[`Response`] used by tests.
use std::str::FromStr;
use crate::http::{
Header, HeaderVec, HttpVersion, Method, Param, RequestCookie, RequestSpec, Response, Url,
};
/// Some Request Response to be used by tests
fn default_response() -> Response {
Response {
version: HttpVersion::Http10,

2
packages/hurl/src/parallel/progress.rs
View File

@ -359,7 +359,7 @@ mod tests {
.enumerate()
.map(|(index, file)| {
Job::new(
&Input::new(*file),
&Input::new(file),
index,
&runner_options,
&variables,

1
packages/hurl/src/runner/filter/to_float.rs
View File

@ -50,6 +50,7 @@ mod tests {
use crate::runner::filter::eval::eval_filter;
use crate::runner::{Number, RunnerErrorKind, Value, VariableSet};
#[allow(clippy::approx_constant)]
#[test]
fn eval_filter_to_float() {
let variable = VariableSet::new();

4
packages/hurl/src/runner/number.rs
View File

@ -155,8 +155,8 @@ mod tests {
let integer_minus_one = Number::from(-1);
let integer_one = Number::from(1);
let integer_two = Number::from(2);
let integer_max = Number::from(i64::max_value());
let integer_min = Number::from(i64::min_value());
let integer_max = Number::from(i64::MAX);
let integer_min = Number::from(i64::MIN);
let float_zero = Number::from(0.0);
let float_one = Number::from(1.0);

4
packages/hurl/src/runner/variable.rs
View File

@ -223,7 +223,7 @@ mod test {
Visibility::Secret
))
);
assert!(variables.get("BAZ").is_none())
assert!(variables.get("BAZ").is_none());
}
#[test]
@ -286,6 +286,6 @@ mod test {
let mut secrets = variables.secrets();
secrets.sort();
assert_eq!(secrets, vec!["1234", "42"])
assert_eq!(secrets, vec!["1234", "42"]);
}
}

2
packages/hurl_core/src/parser/function.rs
View File

@ -54,6 +54,6 @@ mod tests {
let mut reader = Reader::new("name");
let err = parse(&mut reader).unwrap_err();
assert_eq!(err.pos, Pos::new(1, 1));
assert_eq!(err.recoverable, true);
assert!(err.recoverable);
}
}