From 049a8057a8031e4e8c19617e64ac92a907fee83a Mon Sep 17 00:00:00 2001 From: Tyler Wilding Date: Sun, 17 Sep 2023 19:47:26 -0600 Subject: [PATCH] ci: separate lint checks into a required and optional workflow (#3002) --- .github/workflows/linting.yaml | 31 ++++++++++++++++++++----------- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/.github/workflows/linting.yaml b/.github/workflows/linting.yaml index 7ce2100e81..376346bc81 100644 --- a/.github/workflows/linting.yaml +++ b/.github/workflows/linting.yaml @@ -32,8 +32,26 @@ jobs: run: | chmod +x ./third-party/run-clang-format/run-clang-format.py ./third-party/run-clang-format/run-clang-format.py -r common decompiler game goalc test tools lsp --color always - other: - name: 📝 Other Checks + + required-checks: + name: 📝 Required Checks + runs-on: ubuntu-latest + timeout-minutes: 10 + steps: + - name: Checkout Repository + uses: actions/checkout@v3 + + - name: Check for Unresolved Conflicts + run: python ./scripts/gsrc/check-for-conflicts.py + + - name: Check for Incorrect Asserts + run: python ./scripts/ci/check-for-asserts.py + + - name: Check for Invalid Translation Characters + run: python ./scripts/ci/lint-characters.py + + optional-checks: + name: 📝 Optional Checks runs-on: ubuntu-latest timeout-minutes: 10 steps: @@ -49,12 +67,3 @@ jobs: git fetch origin git diff origin/master > lint-changes.diff python ./scripts/ci/lint-gsrc-removals.py - - - name: Check for Unresolved Conflicts - run: python ./scripts/gsrc/check-for-conflicts.py - - - name: Check for Incorrect Asserts - run: python ./scripts/ci/check-for-asserts.py - - - name: Check for Invalid Translation Characters - run: python ./scripts/ci/lint-characters.py