mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-09-03 18:23:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

Allow setting a field with partially defined field (#646)

Browse Source 
* allow setting a field with partially defined field

* actually run the test
This commit is contained in:
water111
2021-06-28 19:20:36 -04:00
committed by GitHub
parent 385b8b5785
commit 2ee48e08f3
5 changed files with 43 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
goalc/compiler/compilation/Define.cpp
+4 -6
View File
@@ -237,17 +237,15 @@ Val* Compiler::do_set(const goos::Object& form, Val* dest, RegVal* src_in_reg, V
// setting somewhere in memory
auto base = as_mem_deref->base;
auto base_as_mco = dynamic_cast<MemoryOffsetConstantVal*>(base);
int load_size = m_ts.get_load_size_allow_partial_def(as_mem_deref->type());
if (base_as_mco) {
// if it is a constant offset, we can use a fancy x86-64 addressing mode to simplify
auto ti = m_ts.lookup_type(as_mem_deref->type());
env->emit(std::make_unique<IR_StoreConstOffset>(
src_in_reg, base_as_mco->offset, base_as_mco->base->to_gpr(env), ti->get_load_size()));
env->emit(std::make_unique<IR_StoreConstOffset>(src_in_reg, base_as_mco->offset,
base_as_mco->base->to_gpr(env), load_size));
return src_in_reg;
} else {
// nope, the pointer to dereference is some complicated thing.
auto ti = m_ts.lookup_type(as_mem_deref->type());
env->emit(std::make_unique<IR_StoreConstOffset>(src_in_reg, 0, base->to_gpr(env),
ti->get_load_size()));
env->emit(std::make_unique<IR_StoreConstOffset>(src_in_reg, 0, base->to_gpr(env), load_size));
return src_in_reg;
}
} else if (as_pair) {