mirror of
https://github.com/open-goal/jak-project
synced 2026-08-22 07:04:29 -04:00
split new pc features in some files into their own code files + address some old issues + ripple graphics improvements (#2216)
Moves PC-specific entity and debug menu things to `entity-debug.gc` and `default-menu-pc.gc` respectively and makes `(declare-file (debug))` work as it should (no need to wrap the entire file in `(when *debug-segment*` now!). Also changes the DGO descriptor format so that it's less verbose. It might break custom levels, but the format change is very simple so it should not be difficult for anyone to update to the new format. Sadly, you lose the completely useless ability to use DGO object names that don't match the source file name. The horror! I've also gone ahead and expanded the force envmap option to also force the ripple effect to be active. I did not notice any performance or visual drawbacks from this. Gets rid of some distracting LOD and some water pools appearing super flat (and pitch back for dark eco). Fixes #1424
This commit is contained in:
@@ -334,7 +334,6 @@ std::string write_from_top_level_form(Form* top_form,
|
||||
}
|
||||
|
||||
// look for the whole thing being in a (when *debug-segment* ....)
|
||||
bool in_debug_only_file = false;
|
||||
if (forms.size() == 1) {
|
||||
auto as_cne = dynamic_cast<CondNoElseElement*>(forms.at(0));
|
||||
if (as_cne && as_cne->entries.size() == 1) {
|
||||
@@ -343,9 +342,7 @@ std::string write_from_top_level_form(Form* top_form,
|
||||
if (entry.condition->to_string(env) == "*debug-segment*") {
|
||||
forms = entry.body->elts();
|
||||
result += ";; this file is debug only\n";
|
||||
result += "(declare-file (debug))\n";
|
||||
result += "(when *debug-segment*\n";
|
||||
in_debug_only_file = true;
|
||||
result += "(declare-file (debug))\n\n";
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -559,10 +556,6 @@ std::string write_from_top_level_form(Form* top_form,
|
||||
}
|
||||
}
|
||||
|
||||
if (in_debug_only_file) {
|
||||
result += ")\n";
|
||||
}
|
||||
|
||||
if (in_rlet) {
|
||||
result += ")\n";
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user