mirror of
https://github.com/open-goal/jak-project
synced 2026-07-29 23:49:11 -04:00
Resolve a good chunk of windows compiler warnings
Mostly revolved around the new MSVC check for functions that don't cover all paths (ie. a switch statement without a default case). It appears to not see an assert as a valid default case. I switched assert(false) to exceptions in these cases. I believe this should also abort the program, but will also provide a hopefully useful message? Hopefully this is an improvement. Resolves #32
This commit is contained in:
@@ -5,6 +5,7 @@
|
||||
|
||||
#include "Register.h"
|
||||
#include <cassert>
|
||||
#include <stdexcept>
|
||||
|
||||
////////////////////////////
|
||||
// Register Name Constants
|
||||
@@ -126,7 +127,7 @@ const char* Register::to_charp() const {
|
||||
case Reg::PCR:
|
||||
return pcr_to_charp(get_pcr());
|
||||
default:
|
||||
assert(false);
|
||||
throw std::runtime_error("Unsupported Register");
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user