mirror of
https://github.com/open-goal/jak-project
synced 2026-09-03 18:23:39 -04:00
Resolve a good chunk of windows compiler warnings
Mostly revolved around the new MSVC check for functions that don't cover all paths (ie. a switch statement without a default case). It appears to not see an assert as a valid default case. I switched assert(false) to exceptions in these cases. I believe this should also abort the program, but will also provide a hopefully useful message? Hopefully this is an improvement. Resolves #32
This commit is contained in:
@@ -884,6 +884,8 @@ s32 format_impl(uint64_t* args) {
|
||||
call_method_of_type(in, type, GOAL_PRINT_METHOD);
|
||||
}
|
||||
} else {
|
||||
// TODO - if we can't throw exceptions, what is the option?
|
||||
// log, break and continue?
|
||||
throw std::runtime_error("failed to find symbol in format!");
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user