mirror of
https://github.com/open-goal/jak-project
synced 2026-08-22 07:04:29 -04:00
[goalc] Cleaned up speedups (#3066)
Started at 349,880,038 allocations and 42s - Switched to making `Symbol` in GOOS be a "fixed type", just a wrapper around a `const char*` pointing to the string in the symbol table. This is a step toward making a lot of things better, but by itself not a huge improvement. Some things may be worse due to more temp `std::string` allocations, but one day all these can be removed. On linux it saved allocations (347,685,429), and saved a second or two (41 s). - cache `#t` and `#f` in interpreter, better lookup for special forms/builtins (hashtable of pointers instead of strings, vector for the small special form list). Dropped time to 38s. - special-case in quasiquote when splicing is the last thing in a list. Allocation dropped to 340,603,082 - custom hash table for environment lookups (lexical vars). Dropped to 36s and 314,637,194 - less allocation in `read_list` 311,613,616. Time about the same. - `let` and `let*` in Interpreter.cpp 191,988,083, time down to 28s.
This commit is contained in:
@@ -3537,7 +3537,7 @@ void FunctionCallElement::update_from_stack(const Env& env,
|
||||
Form* so_group_f = nullptr;
|
||||
if (!elt_group->elts().at(0)->to_form(env).is_symbol("sfx")) {
|
||||
so_group_f = pool.form<ConstantTokenElement>(
|
||||
elt_group->elts().at(0)->to_form(env).as_symbol()->name);
|
||||
elt_group->elts().at(0)->to_form(env).as_symbol().name_ptr);
|
||||
}
|
||||
auto so_positional_f = arg_forms.at(6);
|
||||
if (so_positional_f->to_form(env).is_symbol("#t")) {
|
||||
|
||||
Reference in New Issue
Block a user