logs: replace every fmt::print with a lg call instead (#1368)

Favors the `lg` namespace over `fmt` directly, as this will output the
logs to a file / has log levels.

I also made assertion errors go to a file, this unfortunately means
importing `lg` and hence `fmt` which was attempted to be avoided before.
But I'm not sure how else to do this aspect without re-inventing the
file logging.

We have a lot of commented out prints as well that we should probably
cleanup at some point / switch them to trace level and default to `info`
level.

I noticed the pattern of disabling debug logs behind some boolean,
something to consider cleaning up in the future -- if our logs were more
structured (knowing where they are coming from) then a lot this
boilerplate could be eliminated.

Closes #1358

common/log/log.cpp

@@ -46,10 +46,14 @@ void log_message(level log_level, LogTime& now, const char* message) {
   auto now_milliseconds = now.tv.tv_usec / 1000;
   strftime(date_time_buffer, 128, "%Y-%m-%d %H:%M:%S", localtime(&now_seconds));
   std::string date_string = fmt::format("[{}:{:03d}]", date_time_buffer, now_milliseconds);
+  strftime(date_time_buffer, 128, "%M:%S", localtime(&now_seconds));
+  std::string time_condensed = fmt::format("[{}]:{:03d}]", date_time_buffer, now_milliseconds);
 #else
   char date_time_buffer[128];
   strftime(date_time_buffer, 128, "%Y-%m-%d %H:%M:%S", localtime(&now.tim));
   std::string date_string = fmt::format("[{}]", date_time_buffer);
+  strftime(date_time_buffer, 128, "%M:%S", localtime(&now.tim));
+  std::string time_condensed = fmt::format("[{}]", date_time_buffer);
 #endif
 
   {
@@ -65,11 +69,12 @@ void log_message(level log_level, LogTime& now, const char* message) {
     }
 
     if (log_level >= gLogger.stdout_log_level) {
-      fmt::print("{} [", date_string);
+      fmt::print("{} [", time_condensed);
       fmt::print(fg(log_colors[int(log_level)]), "{}", log_level_names[int(log_level)]);
       fmt::print("] {}\n", message);
       if (log_level >= gLogger.flush_level) {
         fflush(stdout);
+        fflush(stderr);
       }
     }
   }
@@ -78,6 +83,26 @@ void log_message(level log_level, LogTime& now, const char* message) {
     exit(-1);
   }
 }
+
+void log_print(const char* message) {
+  {
+    // We always immediately flush prints because since it has no associated level
+    // it could be anything from a fatal error to a useless debug log.
+    std::lock_guard<std::mutex> lock(gLogger.mutex);
+    if (gLogger.fp) {
+      // Log to File
+      std::string msg(message);
+      fwrite(msg.c_str(), msg.length(), 1, gLogger.fp);
+      fflush(gLogger.fp);
+    }
+
+    if (gLogger.stdout_log_level < lg::level::off) {
+      fmt::print(message);
+      fflush(stdout);
+      fflush(stderr);
+    }
+  }
+}
 }  // namespace internal
 
 void set_file(const std::string& filename) {