logs: replace every `fmt::print` with a `lg` call instead (#1368)

mirror of https://github.com/open-goal/jak-project synced 2026-05-26 15:46:14 -04:00

Favors the `lg` namespace over `fmt` directly, as this will output the
logs to a file / has log levels.

I also made assertion errors go to a file, this unfortunately means
importing `lg` and hence `fmt` which was attempted to be avoided before.
But I'm not sure how else to do this aspect without re-inventing the
file logging.

We have a lot of commented out prints as well that we should probably
cleanup at some point / switch them to trace level and default to `info`
level.

I noticed the pattern of disabling debug logs behind some boolean,
something to consider cleaning up in the future -- if our logs were more
structured (knowing where they are coming from) then a lot this
boilerplate could be eliminated.

Closes #1358

This commit is contained in:

Tyler Wilding

2022-10-01 11:58:36 -04:00

committed by

GitHub

parent 4e48ba21c1

commit 4d751af38e

120 changed files with 990 additions and 893 deletions

									
										decompiler/ObjectFile/LinkedObjectFileCreation.cpp
									
		+1
		
												View File
												
				@@ -9,6 +9,7 @@

				#include <cstring>

				#include "common/link_types.h"

				#include "common/log/log.h"

				#include "common/util/Assert.h"

				#include "common/util/BitUtils.h"

logs: replace every fmt::print with a lg call instead (#1368)

logs: replace every `fmt::print` with a `lg` call instead (#1368)