mirror of
https://github.com/open-goal/jak-project
synced 2026-08-13 04:10:18 -04:00
logs: replace every fmt::print with a lg call instead (#1368)
Favors the `lg` namespace over `fmt` directly, as this will output the logs to a file / has log levels. I also made assertion errors go to a file, this unfortunately means importing `lg` and hence `fmt` which was attempted to be avoided before. But I'm not sure how else to do this aspect without re-inventing the file logging. We have a lot of commented out prints as well that we should probably cleanup at some point / switch them to trace level and default to `info` level. I noticed the pattern of disabling debug logs behind some boolean, something to consider cleaning up in the future -- if our logs were more structured (knowing where they are coming from) then a lot this boilerplate could be eliminated. Closes #1358
This commit is contained in:
@@ -1,5 +1,6 @@
|
||||
#include "expression_build.h"
|
||||
#include "common/goos/PrettyPrinter.h"
|
||||
#include "common/log/log.h"
|
||||
#include "decompiler/Function/Function.h"
|
||||
#include "decompiler/IR2/Form.h"
|
||||
#include "decompiler/IR2/FormStack.h"
|
||||
@@ -46,7 +47,7 @@ bool convert_to_expressions(
|
||||
info.second.name_override = rename->second;
|
||||
}
|
||||
// debug
|
||||
// fmt::print("STACK {} : {} ({})\n", info.first, info.second.typespec.print(),
|
||||
// lg::print("STACK {} : {} ({})\n", info.first, info.second.typespec.print(),
|
||||
// info.second.tp_type.print());
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user