mirror of
https://github.com/open-goal/jak-project
synced 2026-08-21 23:00:45 -04:00
logs: replace every fmt::print with a lg call instead (#1368)
Favors the `lg` namespace over `fmt` directly, as this will output the logs to a file / has log levels. I also made assertion errors go to a file, this unfortunately means importing `lg` and hence `fmt` which was attempted to be avoided before. But I'm not sure how else to do this aspect without re-inventing the file logging. We have a lot of commented out prints as well that we should probably cleanup at some point / switch them to trace level and default to `info` level. I noticed the pattern of disabling debug logs behind some boolean, something to consider cleaning up in the future -- if our logs were more structured (knowing where they are coming from) then a lot this boilerplate could be eliminated. Closes #1358
This commit is contained in:
@@ -2,6 +2,7 @@
|
||||
|
||||
#include "mips2c.h"
|
||||
|
||||
#include "common/log/log.h"
|
||||
#include "common/symbols.h"
|
||||
#include "common/util/print_float.h"
|
||||
#include "decompiler/Disasm/InstructionMatching.h"
|
||||
@@ -1183,7 +1184,7 @@ struct JumpTableBlock {
|
||||
void run_mips2c_jump_table(Function* f,
|
||||
const std::vector<int>& jump_table_locations,
|
||||
GameVersion version) {
|
||||
fmt::print("mips2c-jump on {}\n", f->name());
|
||||
lg::info("mips2c-jump on {}", f->name());
|
||||
u32 magic_code = std::hash<std::string>()(f->name());
|
||||
std::unordered_map<int, int> loc_to_block;
|
||||
for (size_t bb_idx = 0; bb_idx < f->basic_blocks.size(); bb_idx++) {
|
||||
|
||||
Reference in New Issue
Block a user