mirror of
https://github.com/open-goal/jak-project
synced 2026-09-01 01:52:03 -04:00
logs: replace every fmt::print with a lg call instead (#1368)
Favors the `lg` namespace over `fmt` directly, as this will output the logs to a file / has log levels. I also made assertion errors go to a file, this unfortunately means importing `lg` and hence `fmt` which was attempted to be avoided before. But I'm not sure how else to do this aspect without re-inventing the file logging. We have a lot of commented out prints as well that we should probably cleanup at some point / switch them to trace level and default to `info` level. I noticed the pattern of disabling debug logs behind some boolean, something to consider cleaning up in the future -- if our logs were more structured (knowing where they are coming from) then a lot this boilerplate could be eliminated. Closes #1358
This commit is contained in:
@@ -136,11 +136,9 @@ void TexturePool::unload_texture(PcTextureId tex_id, u64 gpu_id) {
|
||||
ASSERT(false);
|
||||
return;
|
||||
}
|
||||
if (tex->is_placeholder) {
|
||||
fmt::print("trying to unload something that was already placholdered: {} {}\n",
|
||||
get_debug_texture_name(tex_id), tex->gpu_textures.size());
|
||||
}
|
||||
ASSERT(!tex->is_placeholder);
|
||||
ASSERT_MSG(!tex->is_placeholder,
|
||||
fmt::format("trying to unload something that was already placholdered: {} {}\n",
|
||||
get_debug_texture_name(tex_id), tex->gpu_textures.size()));
|
||||
auto it = std::find_if(tex->gpu_textures.begin(), tex->gpu_textures.end(),
|
||||
[&](const auto& a) { return a.gl == gpu_id; });
|
||||
ASSERT(it != tex->gpu_textures.end());
|
||||
@@ -378,4 +376,4 @@ std::string TexturePool::get_debug_texture_name(PcTextureId id) {
|
||||
} else {
|
||||
return "???";
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user