mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-09-06 19:21:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

logs: replace every fmt::print with a lg call instead (#1368)

Browse Source 
Favors the `lg` namespace over `fmt` directly, as this will output the
logs to a file / has log levels.

I also made assertion errors go to a file, this unfortunately means
importing `lg` and hence `fmt` which was attempted to be avoided before.
But I'm not sure how else to do this aspect without re-inventing the
file logging.

We have a lot of commented out prints as well that we should probably
cleanup at some point / switch them to trace level and default to `info`
level.

I noticed the pattern of disabling debug logs behind some boolean,
something to consider cleaning up in the future -- if our logs were more
structured (knowing where they are coming from) then a lot this
boilerplate could be eliminated.

Closes #1358
This commit is contained in:
Tyler Wilding
2022-10-01 11:58:36 -04:00
committed by GitHub
parent 4e48ba21c1
commit 4d751af38e
120 changed files with 990 additions and 893 deletions
Download Patch File Download Diff File Expand all files Collapse all files
goalc/compiler/compilation/CompilerControl.cpp
+11 -12
View File
@@ -16,7 +16,6 @@
#include "goalc/data_compiler/dir_tpages.h"
#include "goalc/data_compiler/game_count.h"
#include "goalc/data_compiler/game_text_common.h"
/*!
* Exit the compiler. Disconnects the listener and tells the target to reset itself.
* Will actually exit the next time the REPL runs.
@@ -369,10 +368,10 @@ Val* Compiler::compile_get_info(const goos::Object& form, const goos::Object& re
auto result = m_symbol_info.lookup_exact_name(args.unnamed.at(0).as_symbol()->name);
if (!result) {
fmt::print("No results found.\n");
lg::print("No results found.\n");
} else {
for (auto& info : *result) {
fmt::print("{}", make_symbol_info_description(info));
lg::print("{}", make_symbol_info_description(info));
}
}
@@ -496,11 +495,11 @@ Val* Compiler::compile_autocomplete(const goos::Object& form, const goos::Object
auto time = timer.getMs();
for (auto& x : result) {
fmt::print(" {}\n", x);
lg::print(" {}\n", x);
}
fmt::print("Autocomplete: {}/{} symbols matched, took {:.2f} ms\n", result.size(),
m_symbol_info.symbol_count(), time);
lg::print("Autocomplete: {}/{} symbols matched, took {:.2f} ms\n", result.size(),
m_symbol_info.symbol_count(), time);
return get_none();
}
@@ -562,12 +561,12 @@ Val* Compiler::compile_print_debug_compiler_stats(const goos::Object& form,
auto args = get_va(form, rest);
va_check(form, args, {}, {});
fmt::print("Spill operations (total): {}\n", m_debug_stats.num_spills);
fmt::print("Spill operations (v1 only): {}\n", m_debug_stats.num_spills_v1);
fmt::print("Eliminated moves: {}\n", m_debug_stats.num_moves_eliminated);
fmt::print("Total functions: {}\n", m_debug_stats.total_funcs);
fmt::print("Functions requiring v1: {}\n", m_debug_stats.funcs_requiring_v1_allocator);
fmt::print("Size of autocomplete prefix tree: {}\n", m_symbol_info.symbol_count());
lg::print("Spill operations (total): {}\n", m_debug_stats.num_spills);
lg::print("Spill operations (v1 only): {}\n", m_debug_stats.num_spills_v1);
lg::print("Eliminated moves: {}\n", m_debug_stats.num_moves_eliminated);
lg::print("Total functions: {}\n", m_debug_stats.total_funcs);
lg::print("Functions requiring v1: {}\n", m_debug_stats.funcs_requiring_v1_allocator);
lg::print("Size of autocomplete prefix tree: {}\n", m_symbol_info.symbol_count());
return get_none();
}