From 74d0025974498ea89b3f9c0d9cb3a7f81be64d99 Mon Sep 17 00:00:00 2001 From: Tyler Wilding Date: Wed, 16 Feb 2022 22:12:38 -0500 Subject: [PATCH] decomp: more descriptive error messages (#1178) --- decompiler/main.cpp | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/decompiler/main.cpp b/decompiler/main.cpp index c865d15675..f1625aac91 100644 --- a/decompiler/main.cpp +++ b/decompiler/main.cpp @@ -85,13 +85,21 @@ int main(int argc, char** argv) { // Verify the in_folder is correct // TODO - refactor to use ghc::filesystem, cleanup file_util - if (!file_util::file_exists(in_folder) || - (!config.expected_elf_name.empty() && - !file_util::file_exists(file_util::combine_path(in_folder, config.expected_elf_name)))) { - printf("Aborting - 'in_folder' does not exist or does not contain the expected files\n"); + if (!file_util::file_exists(in_folder)) { + fmt::print("Aborting - 'in_folder' does not exist '{}'\n", in_folder); return 1; } + // Warning message if expected ELF isn't found, user could be using bad assets / didn't extract + // the ISO properly + if (!config.expected_elf_name.empty() && + !file_util::file_exists(file_util::combine_path(in_folder, config.expected_elf_name))) { + fmt::print( + "WARNING - '{}' does not contain the expected ELF file '{}'. Was the ISO extracted " + "properly or is there a version mismatch?\n", + in_folder, config.expected_elf_name); + } + std::vector dgos, objs, strs; for (const auto& dgo_name : config.dgo_names) { dgos.push_back(file_util::combine_path(in_folder, dgo_name));