From 86d770aeebaa0ce9df1695e3b0c2917f40bc9d0f Mon Sep 17 00:00:00 2001 From: Matt Dallmeyer Date: Fri, 26 Apr 2024 08:27:11 -0700 Subject: [PATCH] Fix "logical not is only applied to the left hand side of comparison" warnings (#3484) --- game/kernel/jak2/kmachine_extras.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/game/kernel/jak2/kmachine_extras.cpp b/game/kernel/jak2/kmachine_extras.cpp index 186c2a38bb..0163a1b117 100644 --- a/game/kernel/jak2/kmachine_extras.cpp +++ b/game/kernel/jak2/kmachine_extras.cpp @@ -679,7 +679,7 @@ s32 pc_sr_mode_get_practice_entries_amount() { void pc_sr_mode_get_practice_entry_name(s32 entry_index, u32 name_str_ptr) { std::string name = ""; - if (!g_speedrun_practice_entries.size() <= entry_index) { + if (entry_index < g_speedrun_practice_entries.size()) { name = g_speedrun_practice_entries.at(entry_index).name; } strcpy(Ptr(name_str_ptr).c()->data(), name.c_str()); @@ -687,7 +687,7 @@ void pc_sr_mode_get_practice_entry_name(s32 entry_index, u32 name_str_ptr) { void pc_sr_mode_get_practice_entry_continue_point(s32 entry_index, u32 name_str_ptr) { std::string name = ""; - if (!g_speedrun_practice_entries.size() <= entry_index) { + if (entry_index < g_speedrun_practice_entries.size()) { name = g_speedrun_practice_entries.at(entry_index).continue_point_name; } strcpy(Ptr(name_str_ptr).c()->data(), name.c_str()); @@ -864,7 +864,7 @@ s32 pc_sr_mode_get_custom_category_amount() { void pc_sr_mode_get_custom_category_name(s32 entry_index, u32 name_str_ptr) { std::string name = ""; - if (!g_speedrun_custom_categories.size() <= entry_index) { + if (entry_index < g_speedrun_custom_categories.size()) { name = g_speedrun_custom_categories.at(entry_index).name; } strcpy(Ptr(name_str_ptr).c()->data(), name.c_str()); @@ -872,7 +872,7 @@ void pc_sr_mode_get_custom_category_name(s32 entry_index, u32 name_str_ptr) { void pc_sr_mode_get_custom_category_continue_point(s32 entry_index, u32 name_str_ptr) { std::string name = ""; - if (!g_speedrun_custom_categories.size() <= entry_index) { + if (entry_index < g_speedrun_custom_categories.size()) { name = g_speedrun_custom_categories.at(entry_index).continue_point_name; } strcpy(Ptr(name_str_ptr).c()->data(), name.c_str());