From 95dca764fc592f5a76eeff520e60e2206c997388 Mon Sep 17 00:00:00 2001 From: jabermony <748988+jabermony@users.noreply.github.com> Date: Sun, 15 Oct 2023 15:38:14 +0100 Subject: [PATCH] Fix build failure at llvm-rc on windows due to codepage error on zydis (#3088) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This fix is for the following error when building with llvm on windows ``` [build] llvm-rc: Error in VERSIONINFO statement (ID 1): [proc] The command: "C:\Program Files\CMake\bin\cmake.exe" --build C:/.../git/jak-project-test/out/build/Release --parallel 8 exited with code: 1 [build] Non-ASCII 8-bit codepoint (´┐¢) can't be interpreted in the current codepage [build] ninja: build stopped: subcommand failed. ``` It's caused by llvm-rc not handling non 8-bit characters. The same issue is discussed in the curl project here https://github.com/curl/curl/issues/7765 This commit copies the fix from curl, replacing '©' with '(C)'. --- third-party/zydis/resources/VersionInfo.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third-party/zydis/resources/VersionInfo.rc b/third-party/zydis/resources/VersionInfo.rc index b890973dcc..8c176b7628 100644 --- a/third-party/zydis/resources/VersionInfo.rc +++ b/third-party/zydis/resources/VersionInfo.rc @@ -47,7 +47,7 @@ BEGIN VALUE "FileDescription", "Zyan Disassembler Library" VALUE "FileVersion", "4.0.0.0" VALUE "InternalName", "Zydis" - VALUE "LegalCopyright", "Copyright © 2014-2021 by zyantific.com" + VALUE "LegalCopyright", "Copyright (C) 2014-2021 by zyantific.com" VALUE "OriginalFilename", "Zydis.dll" VALUE "ProductName", "Zyan Disassembler Library" VALUE "ProductVersion", "4.0.0.0"