From a0da98a367e4925b9950d39a9576bf5f29f9afc3 Mon Sep 17 00:00:00 2001 From: water111 <48171810+water111@users.noreply.github.com> Date: Mon, 14 Aug 2023 18:52:25 -0400 Subject: [PATCH] [glow] fix clipping bug (#2902) Now you can be blinded by the sun: ![image](https://github.com/open-goal/jak-project/assets/48171810/caf3903c-8333-4daa-89ba-ff83ca7d6b2f) --- game/graphics/opengl_renderer/sprite/GlowRenderer.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/game/graphics/opengl_renderer/sprite/GlowRenderer.cpp b/game/graphics/opengl_renderer/sprite/GlowRenderer.cpp index b5941beb05..8bb0675d72 100644 --- a/game/graphics/opengl_renderer/sprite/GlowRenderer.cpp +++ b/game/graphics/opengl_renderer/sprite/GlowRenderer.cpp @@ -241,7 +241,9 @@ void copy_to_vertex(GlowRenderer::Vertex* vtx, const Vector4f& xyzw) { vtx->x = xyzw.x(); vtx->y = xyzw.y(); vtx->z = xyzw.z(); - vtx->w = xyzw.w(); + // ignore the w computed by the game, and just use 1. The game's VU program ignores this value, + // and we need to set w = 1 to get the correct opengl clipping behavior + vtx->w = 1; } } // namespace