[decompiler] clean up vector detection and add vector float product detection (#638)

* change

* recognize vector float product and update tests

test/decompiler/reference/engine/collide/collide-frag-h_REF.gc

@@ -104,5 +104,4 @@
   )
 
 ;; failed to figure out what this is:
-(let ((v0-9 0))
-  )
+0

test/decompiler/reference/engine/collide/collide-frag_REF.gc

@@ -37,8 +37,7 @@
   drawable-tree-collide-fragment
   ((obj drawable-tree-collide-fragment) (arg0 int))
   (dummy-11 (-> obj data 0) (-> obj length))
-  (let ((v0-1 0))
-   )
+  0
   (none)
   )
 
@@ -49,8 +48,7 @@
   drawable-tree-collide-fragment
   ((obj drawable-tree-collide-fragment) (arg0 int))
   (dummy-12 (-> obj data 0) (-> obj length))
-  (let ((v0-1 0))
-   )
+  0
   (none)
   )
 
@@ -61,8 +59,7 @@
   drawable-tree-collide-fragment
   ((obj drawable-tree-collide-fragment) (arg0 int))
   (dummy-13 (-> obj data 0) (-> obj length))
-  (let ((v0-1 0))
-   )
+  0
   (none)
   )
 
@@ -162,8 +159,7 @@
   drawable-inline-array-collide-fragment
   ((obj drawable-inline-array-collide-fragment) (arg0 int))
   (dummy-11 (the-as collide-fragment (-> obj data)) (-> obj length))
-  (let ((v0-1 0))
-   )
+  0
   (none)
   )
 
@@ -174,8 +170,7 @@
   drawable-inline-array-collide-fragment
   ((obj drawable-inline-array-collide-fragment) (arg0 int))
   (dummy-12 (the-as collide-fragment (-> obj data)) (-> obj length))
-  (let ((v0-1 0))
-   )
+  0
   (none)
   )
 
@@ -186,8 +181,7 @@
   drawable-inline-array-collide-fragment
   ((obj drawable-inline-array-collide-fragment) (arg0 int))
   (dummy-13 (the-as collide-fragment (-> obj data)) (-> obj length))
-  (let ((v0-1 0))
-   )
+  0
   (none)
   )
 
@@ -214,7 +208,3 @@
    )
   obj
   )
-
-
-
-

test/decompiler/reference/engine/collide/collide-touch-h_REF.gc

@@ -108,8 +108,7 @@
   (let ((t9-0 (method-of-type structure new))
         (v1-1 type-to-make)
         )
-   (let ((a2-0 (-> type-to-make size)))
-    )
+   (-> type-to-make size)
    (let ((gp-0 (t9-0 allocation v1-1)))
     ((method-of-type touching-prims-entry-pool init-list!)
      (the-as touching-prims-entry-pool gp-0)
@@ -187,8 +186,7 @@
   (let ((t9-0 (method-of-type structure new))
         (v1-1 type-to-make)
         )
-   (let ((a2-0 (-> type-to-make size)))
-    )
+   (-> type-to-make size)
    (let ((obj (the-as touching-list (t9-0 allocation v1-1))))
     (set! (-> obj num-touching-shapes) 0)
     (set! (-> obj resolve-u) 0)