Recognize auto-generated inspect methods and create deftypes from them (#95)

- Recognize new type definitions/parents/type flags in the decompiler
- Analyze autogenerated inspect methods and dump guesses at fields to a file
- Utility functions for accessing static data by label
- Better ordering in the decompiler to go through functions in the order they appeared in the source
- Added a decent number of types to `all-types.gc` based on the new field analyzer
- Correct a few `int`/`integer` mistakes in `gcommon.gc` (this should really be a warning)
- Correct a few type issues in `gcommon` and `gkernel-h`
- Option in the decompiler to be strict about `define-extern` redefining a type of a symbol
- Add a test to check consistency in types between `all-types.gc` (used by decompiler) and `goal_src` (used by the compiler)

decompiler/ObjectFile/ObjectFileDB.cpp

@@ -20,6 +20,7 @@
 #include "decompiler/Function/BasicBlocks.h"
 #include "decompiler/IR/BasicOpBuilder.h"
 #include "decompiler/IR/CfgBuilder.h"
+#include "decompiler/Function/TypeInspector.h"
 #include "third-party/spdlog/include/spdlog/spdlog.h"
 #include "third-party/json.hpp"
 
@@ -625,7 +626,8 @@ void ObjectFileDB::analyze_functions() {
         assert(func.guessed_name.empty());
         func.guessed_name.set_as_top_level();
         func.find_global_function_defs(data.linked_data, dts);
-        func.find_method_defs(data.linked_data);
+        func.find_type_defs(data.linked_data, dts);
+        func.find_method_defs(data.linked_data, dts);
       }
     });
 
@@ -687,10 +689,11 @@ void ObjectFileDB::analyze_functions() {
   int successful_type_analysis = 0;
 
   std::map<int, std::vector<std::string>> unresolved_by_length;
+
   if (get_config().find_basic_blocks) {
     timer.start();
     int total_basic_blocks = 0;
-    for_each_function([&](Function& func, int segment_id, ObjectFileData& data) {
+    for_each_function_def_order([&](Function& func, int segment_id, ObjectFileData& data) {
       //      printf("in %s from %s\n", func.guessed_name.to_string().c_str(),
       //             data.to_unique_name().c_str());
       auto blocks = find_blocks_in_function(data.linked_data, segment_id, func);
@@ -718,6 +721,12 @@ void ObjectFileDB::analyze_functions() {
         total_basic_ops += func.get_basic_op_count();
         total_failed_basic_ops += func.get_failed_basic_op_count();
 
+        if (func.is_inspect_method) {
+          auto result = inspect_inspect_method(func, func.method_of_type, dts, data.linked_data);
+          all_type_defs += ";; " + data.to_unique_name() + "\n";
+          all_type_defs += result.print_as_deftype() + "\n";
+        }
+
         // Combine basic ops + CFG to build a nested IR
         func.ir = build_cfg_ir(func, *func.cfg, data.linked_data);
         non_asm_funcs++;
@@ -744,11 +753,13 @@ void ObjectFileDB::analyze_functions() {
             }
             // GOOD!
             func.type = kv->second;
+
             /*
             spdlog::info("Type Analysis on {} {}", func.guessed_name.to_string(),
                          kv->second.print());
             func.run_type_analysis(kv->second, dts, data.linked_data);
              */
+
             if (func.has_typemaps()) {
               successful_type_analysis++;
             }