From c235280b912a760abe3995377dcc17c8b32e8b1b Mon Sep 17 00:00:00 2001 From: water111 <48171810+water111@users.noreply.github.com> Date: Sun, 12 Jun 2022 12:58:10 -0400 Subject: [PATCH] [decomp] clean up files 50-100 (#1443) * [decomp] clean up files 50-100 * update file, fix crash on too many prims * spelling is hard --- decompiler/IR2/FormExpressionAnalysis.cpp | 44 ++++--- decompiler/config/all-types.gc | 119 +++++++---------- game/mips2c/functions/collide_cache.cpp | 2 +- goal_src/engine/anim/bones-h.gc | 4 + goal_src/engine/anim/bones.gc | 6 +- goal_src/engine/anim/joint-h.gc | 2 +- goal_src/engine/anim/joint.gc | 40 +++--- goal_src/engine/anim/mspace-h.gc | 12 +- goal_src/engine/camera/cam-debug.gc | 2 +- goal_src/engine/camera/cam-master.gc | 8 +- goal_src/engine/camera/cam-states.gc | 24 ++-- goal_src/engine/collide/collide-cache-h.gc | 8 +- goal_src/engine/collide/collide-cache.gc | 50 ++++---- goal_src/engine/collide/collide-edge-grab.gc | 14 +- .../engine/collide/collide-reaction-target.gc | 6 +- goal_src/engine/collide/collide-shape.gc | 118 ++++++++--------- goal_src/engine/data/art-h.gc | 9 +- goal_src/engine/debug/memory-usage-h.gc | 19 +-- goal_src/engine/draw/draw-node-h.gc | 5 +- goal_src/engine/draw/drawable-ambient-h.gc | 6 +- goal_src/engine/draw/drawable-h.gc | 6 +- .../engine/draw/drawable-inline-array-h.gc | 1 + goal_src/engine/draw/process-drawable.gc | 20 +-- goal_src/engine/game/game-info-h.gc | 57 +++++---- goal_src/engine/game/powerups.gc | 2 +- goal_src/engine/game/task/hint-control-h.gc | 20 ++- goal_src/engine/game/task/process-taskable.gc | 8 +- goal_src/engine/gfx/generic/generic-h.gc | 15 +++ goal_src/engine/gfx/generic/generic-vu1-h.gc | 10 +- goal_src/engine/gfx/generic/generic-work-h.gc | 2 + goal_src/engine/gfx/lights-h.gc | 2 + goal_src/engine/gfx/merc/generic-merc-h.gc | 3 + goal_src/engine/gfx/merc/merc-h.gc | 111 ++++++++++------ goal_src/engine/gfx/mood-h.gc | 4 +- goal_src/engine/gfx/shadow/shadow-cpu-h.gc | 49 +++---- goal_src/engine/gfx/shadow/shadow-cpu.gc | 6 +- goal_src/engine/gfx/texture.gc | 30 ++--- goal_src/engine/gfx/tie/generic-tie-h.gc | 2 + goal_src/engine/gfx/tie/prototype-h.gc | 8 +- goal_src/engine/gfx/wind-h.gc | 3 +- goal_src/engine/target/logic-target.gc | 16 +-- goal_src/engine/target/pat-h.gc | 23 ++-- goal_src/engine/target/surface-h.gc | 120 +++++++++--------- goal_src/engine/target/target-death.gc | 6 +- goal_src/engine/target/target-handler.gc | 6 +- goal_src/engine/target/target-util.gc | 12 +- goal_src/engine/target/target.gc | 18 +-- goal_src/engine/target/target2.gc | 8 +- goal_src/levels/beach/bird-lady.gc | 4 +- goal_src/levels/beach/mayor.gc | 2 +- goal_src/levels/beach/sculptor.gc | 4 +- goal_src/levels/beach/seagull.gc | 3 +- goal_src/levels/citadel/citadel-sages.gc | 12 +- goal_src/levels/common/basebutton.gc | 4 +- goal_src/levels/common/joint-exploder.gc | 2 +- goal_src/levels/common/nav-enemy.gc | 2 +- goal_src/levels/common/plat-button.gc | 4 +- goal_src/levels/finalboss/green-eco-lurker.gc | 8 +- goal_src/levels/finalboss/robotboss.gc | 4 +- goal_src/levels/flut_common/flutflut.gc | 2 +- goal_src/levels/flut_common/target-flut.gc | 17 +-- goal_src/levels/jungle/fisher.gc | 4 +- goal_src/levels/jungle/jungle-mirrors.gc | 4 +- goal_src/levels/jungleb/plant-boss.gc | 2 +- goal_src/levels/maincave/dark-crystal.gc | 2 +- goal_src/levels/maincave/driller-lurker.gc | 2 +- goal_src/levels/maincave/maincave-obs.gc | 4 +- goal_src/levels/maincave/mother-spider-egg.gc | 16 +-- goal_src/levels/maincave/mother-spider.gc | 22 ++-- goal_src/levels/maincave/spiderwebs.gc | 2 +- goal_src/levels/misty/misty-conveyor.gc | 8 +- goal_src/levels/misty/mistycannon.gc | 2 +- goal_src/levels/ogre/flying-lurker.gc | 10 +- goal_src/levels/ogre/ogreboss.gc | 10 +- goal_src/levels/racer_common/racer.gc | 2 +- goal_src/levels/racer_common/target-racer.gc | 4 +- goal_src/levels/rolling/rolling-robber.gc | 2 +- goal_src/levels/snow/ice-cube.gc | 2 +- goal_src/levels/snow/snow-ball.gc | 2 +- goal_src/levels/snow/snow-flutflut-obs.gc | 2 +- goal_src/levels/snow/snow-ram-boss.gc | 2 +- goal_src/levels/sunken/bully.gc | 6 +- goal_src/levels/sunken/double-lurker.gc | 6 +- goal_src/levels/sunken/puffer.gc | 10 +- goal_src/levels/sunken/target-tube.gc | 4 +- goal_src/levels/swamp/kermit.gc | 2 +- goal_src/levels/training/training-obs.gc | 4 +- goal_src/levels/village1/assistant.gc | 5 +- goal_src/levels/village1/explorer.gc | 4 +- .../levels/village2/assistant-village2.gc | 6 +- goal_src/levels/village2/warrior.gc | 4 +- .../levels/village3/assistant-village3.gc | 4 +- goal_src/levels/village3/miners.gc | 8 +- goal_src/levels/village3/sage-village3.gc | 4 +- goal_src/levels/village3/village3-obs.gc | 2 +- .../levels/village_common/villagep-obs.gc | 4 +- .../reference/engine/anim/joint-h_REF.gc | 2 +- .../reference/engine/anim/joint_REF.gc | 4 +- .../reference/engine/anim/mspace-h_REF.gc | 2 +- .../reference/engine/camera/cam-master_REF.gc | 8 +- .../reference/engine/camera/cam-states_REF.gc | 24 ++-- .../engine/collide/collide-cache-h_REF.gc | 8 +- .../engine/collide/collide-edge-grab_REF.gc | 10 +- .../collide/collide-reaction-target_REF.gc | 22 +++- .../engine/draw/process-drawable_REF.gc | 12 +- .../reference/engine/game/powerups_REF.gc | 2 +- .../engine/game/task/process-taskable_REF.gc | 8 +- .../engine/target/logic-target_REF.gc | 16 +-- .../reference/engine/target/surface-h_REF.gc | 48 +++---- .../engine/target/target-death_REF.gc | 7 +- .../engine/target/target-handler_REF.gc | 6 +- .../engine/target/target-util_REF.gc | 12 +- .../reference/engine/target/target2_REF.gc | 8 +- .../reference/engine/target/target_REF.gc | 22 ++-- .../reference/levels/beach/bird-lady_REF.gc | 4 +- .../reference/levels/beach/mayor_REF.gc | 2 +- .../reference/levels/beach/sculptor_REF.gc | 4 +- .../reference/levels/beach/seagull_REF.gc | 2 +- .../levels/citadel/citadel-sages_REF.gc | 12 +- .../reference/levels/common/basebutton_REF.gc | 2 +- .../levels/common/joint-exploder_REF.gc | 10 +- .../reference/levels/common/nav-enemy_REF.gc | 2 +- .../levels/common/plat-button_REF.gc | 4 +- .../levels/finalboss/green-eco-lurker_REF.gc | 8 +- .../levels/finalboss/robotboss_REF.gc | 4 +- .../levels/flut_common/flutflut_REF.gc | 2 +- .../levels/flut_common/target-flut_REF.gc | 18 +-- .../reference/levels/jungle/fisher_REF.gc | 4 +- .../levels/jungle/jungle-mirrors_REF.gc | 4 +- .../levels/jungleb/plant-boss_REF.gc | 2 +- .../levels/maincave/dark-crystal_REF.gc | 11 +- .../levels/maincave/driller-lurker_REF.gc | 2 +- .../levels/maincave/maincave-obs_REF.gc | 4 +- .../levels/maincave/mother-spider-egg_REF.gc | 25 ++-- .../levels/maincave/mother-spider_REF.gc | 31 +++-- .../levels/maincave/spiderwebs_REF.gc | 2 +- .../levels/misty/misty-conveyor_REF.gc | 8 +- .../reference/levels/misty/mistycannon_REF.gc | 2 +- .../levels/ogre/flying-lurker_REF.gc | 19 ++- .../reference/levels/ogre/ogreboss_REF.gc | 8 +- .../levels/racer_common/racer_REF.gc | 2 +- .../levels/racer_common/target-racer_REF.gc | 4 +- .../levels/rolling/rolling-robber_REF.gc | 2 +- .../reference/levels/snow/ice-cube_REF.gc | 2 +- .../reference/levels/snow/snow-ball_REF.gc | 2 +- .../levels/snow/snow-flutflut-obs_REF.gc | 2 +- .../levels/snow/snow-ram-boss_REF.gc | 2 +- .../reference/levels/sunken/bully_REF.gc | 6 +- .../levels/sunken/double-lurker_REF.gc | 6 +- .../reference/levels/sunken/puffer_REF.gc | 10 +- .../levels/sunken/target-tube_REF.gc | 4 +- .../reference/levels/swamp/kermit_REF.gc | 2 +- .../levels/training/training-obs_REF.gc | 4 +- .../levels/village1/assistant_REF.gc | 4 +- .../reference/levels/village1/explorer_REF.gc | 4 +- .../levels/village2/assistant-village2_REF.gc | 6 +- .../reference/levels/village2/warrior_REF.gc | 4 +- .../levels/village3/assistant-village3_REF.gc | 4 +- .../reference/levels/village3/miners_REF.gc | 8 +- .../levels/village3/sage-village3_REF.gc | 4 +- .../levels/village3/village3-obs_REF.gc | 2 +- .../levels/village_common/villagep-obs_REF.gc | 2 +- 162 files changed, 968 insertions(+), 846 deletions(-) diff --git a/decompiler/IR2/FormExpressionAnalysis.cpp b/decompiler/IR2/FormExpressionAnalysis.cpp index 557376e5d8..ffed5d960e 100644 --- a/decompiler/IR2/FormExpressionAnalysis.cpp +++ b/decompiler/IR2/FormExpressionAnalysis.cpp @@ -4021,6 +4021,24 @@ std::vector