mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-08-21 14:54:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

[decompiler] automatically label things when possible (#784)

Browse Source 
* improve label system

* clean up menu

* debug menu working, still need to fix tests

* fix tests and clean up
This commit is contained in:
water111
2021-08-29 11:13:06 -04:00
committed by GitHub
parent 24fe2c78c0
commit d9f9e076af
54 changed files with 11632 additions and 2950 deletions
Download Patch File Download Diff File Expand all files Collapse all files
decompiler/analysis/static_refs.cpp
+7 -8
View File
@@ -24,18 +24,17 @@ bool try_convert_lambda(const Function& parent_function,
if (atom && atom->is_static_addr()) {
auto lab = parent_function.ir2.env.file->labels.at(atom->label());
auto& env = parent_function.ir2.env;
auto label_kv = env.label_types().find(lab.name);
if (label_kv != env.label_types().end()) {
if (label_kv->second.type_name != "_lambda_") {
lg::error(
"Label {} wasn't marked as a lambda, but it is. Marking lambdas is no longer required.",
lab.name);
}
}
const auto& info = parent_function.ir2.env.file->label_db->lookup(lab.name);
auto& file = env.file;
auto other_func = file->try_get_function_at_label(atom->label());
if (other_func && kind_for_lambda(other_func->guessed_name.kind)) {
if (info.from_user) {
lg::error(
"Label {} had an entry in config, but it is a function. This will be "
"ignored and is no longer required.",
lab.name);
}
if (!other_func->ir2.env.has_local_vars()) {
// don't bother if we don't even have vars.
return false;